Re: [PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect()

2012-12-26 Thread Pablo Neira Ayuso
On Wed, Dec 26, 2012 at 10:49:40PM +0100, Jesper Juhl wrote: > 'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember > to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping > to the 'err_out' label rather than the 'out' label in > ctnetlink_create_expect(). > This

[PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect()

2012-12-26 Thread Jesper Juhl
'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping to the 'err_out' label rather than the 'out' label in ctnetlink_create_expect(). This patch should get rid of the leak. Signed-off-by: Jesper Juhl ---

[PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect()

2012-12-26 Thread Jesper Juhl
'if ((!help) (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping to the 'err_out' label rather than the 'out' label in ctnetlink_create_expect(). This patch should get rid of the leak. Signed-off-by: Jesper Juhl

Re: [PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect()

2012-12-26 Thread Pablo Neira Ayuso
On Wed, Dec 26, 2012 at 10:49:40PM +0100, Jesper Juhl wrote: 'if ((!help) (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping to the 'err_out' label rather than the 'out' label in ctnetlink_create_expect(). This patch