Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-22 Thread Pablo Neira Ayuso
On Mon, Oct 21, 2013 at 01:14:53PM +0100, Will Deacon wrote: > On Fri, Oct 18, 2013 at 06:18:13PM +0100, Eric Dumazet wrote: > > On Fri, 2013-10-18 at 17:57 +0100, Will Deacon wrote: > > > Hi Pablo, > > > > > > > > > We also need fixes for net/ipv6/netfilter/ip6_tables.c and > > > > net/ipv4/netf

Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-21 Thread Will Deacon
On Fri, Oct 18, 2013 at 06:18:13PM +0100, Eric Dumazet wrote: > On Fri, 2013-10-18 at 17:57 +0100, Will Deacon wrote: > > Hi Pablo, > > > > > > We also need fixes for net/ipv6/netfilter/ip6_tables.c and > > > net/ipv4/netfilter/arp_tables.c as well. Could you extend this patch > > > and resend? >

Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-18 Thread Eric Dumazet
On Fri, 2013-10-18 at 17:57 +0100, Will Deacon wrote: > Hi Pablo, > > > We also need fixes for net/ipv6/netfilter/ip6_tables.c and > > net/ipv4/netfilter/arp_tables.c as well. Could you extend this patch > > and resend? > > Sure, I can try, but that's going to require a bit of time to sit down a

Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-18 Thread Will Deacon
Hi Pablo, On Fri, Oct 18, 2013 at 12:15:36PM +0100, Pablo Neira Ayuso wrote: > On Thu, Oct 17, 2013 at 02:24:33PM +0100, Will Deacon wrote: > > During kernel stability testing on an SMP ARMv7 system, Yalin Wang > > reported the following panic from the netfilter code: [...] > > This patch adds a

Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-18 Thread Pablo Neira Ayuso
On Thu, Oct 17, 2013 at 02:24:33PM +0100, Will Deacon wrote: > During kernel stability testing on an SMP ARMv7 system, Yalin Wang > reported the following panic from the netfilter code: > > 1fe0: 001c 5e2d3b10 4007e779 4009e110 6010 0032 ff565656 > ff545454 > [] (ipt_do_table+0x44

Re: [PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-17 Thread Eric Dumazet
On Thu, 2013-10-17 at 14:24 +0100, Will Deacon wrote: > During kernel stability testing on an SMP ARMv7 system, Yalin Wang > reported the following panic from the netfilter code: > > On weakly ordered memory architectures, the writes to table->private > and newinfo->jumpstack from CPU1 can be obs

[PATCH] netfilter: fix ordering of jumpstack allocation and table update

2013-10-17 Thread Will Deacon
During kernel stability testing on an SMP ARMv7 system, Yalin Wang reported the following panic from the netfilter code: 1fe0: 001c 5e2d3b10 4007e779 4009e110 6010 0032 ff565656 ff545454 [] (ipt_do_table+0x448/0x584) from [] (nf_iterate+0x48/0x7c) [] (nf_iterate+0x48/0x7c) from