Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread David Miller
From: Jianyu Zhan Date: Tue, 22 Apr 2014 19:25:41 +0800 > I don't think that the value of one field(early_init) has a so subtle > restrition on the another field(css_alloc) is a good thing, but since > it is there, docment it should be needed. This is not a reasonable change. We depend upon

Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread Jianyu Zhan
On Tue, Apr 22, 2014 at 7:19 PM, Neil Horman wrote: > NACK, for the same reason that it doesn't make sense for net_classid. > Early_init should already be zero. What problem are you trying to solve here? Hi, Neil, I'm sorry I should have made this more clear. Sure, for this global variable

Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread Neil Horman
On Tue, Apr 22, 2014 at 01:32:02PM +0800, Jianyu Zhan wrote: > For a cgroup subsystem who should init early, then it should carefully > take care of the implementation of css_alloc, because it will be called > before mm_init() setup the world. > > Luckily we don't, and we better explicitly assign

Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread Neil Horman
On Tue, Apr 22, 2014 at 01:32:02PM +0800, Jianyu Zhan wrote: For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the

Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread Jianyu Zhan
On Tue, Apr 22, 2014 at 7:19 PM, Neil Horman nhor...@tuxdriver.com wrote: NACK, for the same reason that it doesn't make sense for net_classid. Early_init should already be zero. What problem are you trying to solve here? Hi, Neil, I'm sorry I should have made this more clear. Sure, for this

Re: [PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-22 Thread David Miller
From: Jianyu Zhan nasa4...@gmail.com Date: Tue, 22 Apr 2014 19:25:41 +0800 I don't think that the value of one field(early_init) has a so subtle restrition on the another field(css_alloc) is a good thing, but since it is there, docment it should be needed. This is not a reasonable change. We

[PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-21 Thread Jianyu Zhan
For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0, for document reason. Signed-off-by: Jianyu

[PATCH] netprio_cgroup: explicitly init the early_init field

2014-04-21 Thread Jianyu Zhan
For a cgroup subsystem who should init early, then it should carefully take care of the implementation of css_alloc, because it will be called before mm_init() setup the world. Luckily we don't, and we better explicitly assign the early_init field to 0, for document reason. Signed-off-by: Jianyu