Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-22 Thread Olof Johansson
On Tue, Feb 20, 2007 at 07:37:18PM -0500, Trond Myklebust wrote: > Looks like we need a check in nfs_getattr() for a regular file. It makes > no sense to call nfs_sync_mapping_range() on anything else. I think that > should fix your problem: it will stop the NFS client from interfering > with

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-22 Thread Olof Johansson
On Tue, Feb 20, 2007 at 07:37:18PM -0500, Trond Myklebust wrote: Looks like we need a check in nfs_getattr() for a regular file. It makes no sense to call nfs_sync_mapping_range() on anything else. I think that should fix your problem: it will stop the NFS client from interfering with dirty

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Trond Myklebust
On Tue, 2007-02-20 at 11:23 -0600, Olof Johansson wrote: > In my original reproduction, I had to boot with nfs root, and try to mount > my sata drive (/dev/sda3). This is with a static /dev, no udev. Seems like it > happens when trying to mount any block device that's located on NFS. > > Since

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Olof Johansson
On Tue, Feb 20, 2007 at 10:10:00AM -0500, Trond Myklebust wrote: > > Trond, is your MAINTAINERS entry up to date? Seems like you mostly post > > from @netapp.com these days. > > I tend to be easier to get hold of via the fys.uio.no address, since > that isn't hidden behind a VPN. I use the

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Trond Myklebust
On Fri, 2007-02-16 at 11:05 -0600, Olof Johansson wrote: > Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: > > BUG: spinlock bad magic on CPU#0, mount/1073 > lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 > Call Trace: > [C0007E913750]

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Trond Myklebust
On Fri, 2007-02-16 at 11:05 -0600, Olof Johansson wrote: Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: BUG: spinlock bad magic on CPU#0, mount/1073 lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 Call Trace: [C0007E913750]

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Olof Johansson
On Tue, Feb 20, 2007 at 10:10:00AM -0500, Trond Myklebust wrote: Trond, is your MAINTAINERS entry up to date? Seems like you mostly post from @netapp.com these days. I tend to be easier to get hold of via the fys.uio.no address, since that isn't hidden behind a VPN. I use the netapp.com

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-20 Thread Trond Myklebust
On Tue, 2007-02-20 at 11:23 -0600, Olof Johansson wrote: In my original reproduction, I had to boot with nfs root, and try to mount my sata drive (/dev/sda3). This is with a static /dev, no udev. Seems like it happens when trying to mount any block device that's located on NFS. Since this

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-18 Thread Olof Johansson
On Fri, Feb 16, 2007 at 05:24:42PM -0800, Andrew Morton wrote: > req_lock is initialsied in fs/nfs/inode.c:init_once(). Oh, it is indeed. Grmbl. > What kernel version were you using? I've reproduced this on a base 2.6.20 g5_defconfig + NFS root and serial console options on a G5 here. The

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-18 Thread Olof Johansson
On Fri, Feb 16, 2007 at 05:24:42PM -0800, Andrew Morton wrote: req_lock is initialsied in fs/nfs/inode.c:init_once(). Oh, it is indeed. Grmbl. What kernel version were you using? I've reproduced this on a base 2.6.20 g5_defconfig + NFS root and serial console options on a G5 here. The steps

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Andrew Morton
On Fri, 16 Feb 2007 11:05:32 -0600 [EMAIL PROTECTED] (Olof Johansson) wrote: > Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: > > BUG: spinlock bad magic on CPU#0, mount/1073 > lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 > Call Trace: >

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Andrew Morton
On Fri, 16 Feb 2007 11:05:32 -0600 [EMAIL PROTECTED] (Olof Johansson) wrote: > + nfsi->req_lock = SPIN_LOCK_UNLOCKED; This can confound lockdep. Please use spin_lock_init(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

[PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Olof Johansson
Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: BUG: spinlock bad magic on CPU#0, mount/1073 lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 Call Trace: [C0007E913750] [C00107B4] .show_stack+0x54/0x1f0 (unreliable) [C0007E913800]

[PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Olof Johansson
Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: BUG: spinlock bad magic on CPU#0, mount/1073 lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 Call Trace: [C0007E913750] [C00107B4] .show_stack+0x54/0x1f0 (unreliable) [C0007E913800]

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Andrew Morton
On Fri, 16 Feb 2007 11:05:32 -0600 [EMAIL PROTECTED] (Olof Johansson) wrote: + nfsi-req_lock = SPIN_LOCK_UNLOCKED; This can confound lockdep. Please use spin_lock_init(). - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] nfs: init req_lock in nfs_alloc_inode

2007-02-16 Thread Andrew Morton
On Fri, 16 Feb 2007 11:05:32 -0600 [EMAIL PROTECTED] (Olof Johansson) wrote: Seems like req_lock is never initialized. CONFIG_DEBUG_SPINLOCK reported: BUG: spinlock bad magic on CPU#0, mount/1073 lock: c0007fdca108, .magic: , .owner: /24576, .owner_cpu: 0 Call Trace: