Re: [PATCH] nfsd: fix bad offset use

2013-03-22 Thread Kent Overstreet
On Fri, Mar 22, 2013 at 04:54:34PM -0400, J. Bruce Fields wrote: > On Fri, Mar 22, 2013 at 04:53:53PM -0400, J. Bruce Fields wrote: > > On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > > > vfs_writev() updates the offset argument - but the code then passes the > > > offset to vfs_

Re: [PATCH] nfsd: fix bad offset use

2013-03-22 Thread J. Bruce Fields
On Fri, Mar 22, 2013 at 04:53:53PM -0400, J. Bruce Fields wrote: > On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > > vfs_writev() updates the offset argument - but the code then passes the > > offset to vfs_fsync_range(). Since offset now points to the offset after > > what was j

Re: [PATCH] nfsd: fix bad offset use

2013-03-22 Thread J. Bruce Fields
On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > vfs_writev() updates the offset argument - but the code then passes the > offset to vfs_fsync_range(). Since offset now points to the offset after > what was just written, this is probably not what was intended Whoops--thanks! Loo

Re: [PATCH] nfsd: fix bad offset use

2013-03-22 Thread Zach Brown
On Fri, Mar 22, 2013 at 11:18:24AM -0700, Kent Overstreet wrote: > vfs_writev() updates the offset argument - but the code then passes the > offset to vfs_fsync_range(). Since offset now points to the offset after > what was just written, this is probably not what was intended Agreed, the original

[PATCH] nfsd: fix bad offset use

2013-03-22 Thread Kent Overstreet
vfs_writev() updates the offset argument - but the code then passes the offset to vfs_fsync_range(). Since offset now points to the offset after what was just written, this is probably not what was intended Signed-off-by: Kent Overstreet Cc: "J. Bruce Fields" Cc: Al Viro Cc: "Eric W. Biederman"