Re: [PATCH] nfsd4: fix acl buffer overrun

2014-02-11 Thread J. Bruce Fields
On Tue, Feb 11, 2014 at 12:25:48PM -0800, Christoph Hellwig wrote: > Looks good and sorry for the regression. Well, my fault for not reviewing the patch, I saw it and didn't give it more than a skim. Not sure I would have caught that, though. The only thing I can think of that might have made it

Re: [PATCH] nfsd4: fix acl buffer overrun

2014-02-11 Thread Christoph Hellwig
Looks good and sorry for the regression. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] nfsd4: fix acl buffer overrun

2014-02-11 Thread J. Bruce Fields
From: "J. Bruce Fields" 4ac7249ea5a0ceef9f8269f63f33cc873c3fac61 "nfsd: use get_acl and ->set_acl" forgets to set the size in the case get_acl() succeeds, so _posix_to_nfsv4_one() can then write past the end of its allocation. Symptoms were slab corruption warnings. Also, some minor cleanup whil