Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

2005-04-05 Thread Jörn Engel
On Tue, 5 April 2005 12:39:44 +0200, Jesper Juhl wrote: > On Tue, 5 Apr 2005, David Howells wrote: > > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > > > kfree() takes a void pointer argument, no need to cast. > > > > vma->vm_start is unsigned long (unless it's changed since last I looked): > > >

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

2005-04-05 Thread Jesper Juhl
On Tue, 5 Apr 2005, David Howells wrote: > Date: Tue, 05 Apr 2005 11:04:58 +0100 > From: David Howells <[EMAIL PROTECTED]> > To: Jesper Juhl <[EMAIL PROTECTED]> > Cc: linux-kernel > Subject: Re: [PATCH] no need to cast pointer to (void *) when passing it to >

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

2005-04-05 Thread David Howells
Jesper Juhl <[EMAIL PROTECTED]> wrote: > kfree() takes a void pointer argument, no need to cast. vma->vm_start is unsigned long (unless it's changed since last I looked): struct vm_area_struct { struct mm_struct * vm_mm; unsigned long vm_start;

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

2005-04-04 Thread Jesper Juhl
On Mon, 4 Apr 2005, Jesper Juhl wrote: > > kfree() takes a void pointer argument, no need to cast. > I'm an idiot, vm_start is an unsigned long, of course it needs to be cast.. D'OH! Don't apply that patch... Don't know what I was thinking. -- Jesper - To unsubscribe from this list: send

[PATCH] no need to cast pointer to (void *) when passing it to kfree()

2005-04-04 Thread Jesper Juhl
kfree() takes a void pointer argument, no need to cast. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm4-orig/mm/nommu.c2005-03-31 21:20:08.0 +0200 +++ linux-2.6.12-rc1-mm4/mm/nommu.c 2005-04-04 23:25:23.0 +0200 @@ -761,7 +761,7 @@ static void