RE: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super

: [PATCH] ntfs: avoid incorrectly release for root inode in > fill_super > > Hi, > > NAK > > This patch is incorrect. Perhaps you failed to see the ihold() above the > d_make_root() call? > That means we hold two references on the inode - one from the > load_system_fil

Re: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super

Hi, NAK This patch is incorrect. Perhaps you failed to see the ihold() above the d_make_root() call? That means we hold two references on the inode - one from the load_system_files()::ntfs_iget() and one from the ihold() before d_make_root(). Thus in the error code path d_make_root() does i

[PATCH] ntfs: avoid incorrectly release for root inode in fill_super

In d_make_root, when we fail to allocate dentry for root inode, we will iput root inode in this function. So we do not need to release this inode again at d_make_root's caller. Signed-off-by: Chao Yu --- fs/ntfs/super.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/