Re: [RESEND PATCH] nvme: Use spin_lock_irqsave() when taking the ctrl->lock

2020-08-12 Thread Logan Gunthorpe
On 2020-08-12 3:19 p.m., Keith Busch wrote: > On Wed, Aug 12, 2020 at 03:01:19PM -0600, Logan Gunthorpe wrote: >> @@ -2971,15 +2971,16 @@ int nvme_get_log(struct nvme_ctrl *ctrl, u32 nsid, >> u8 log_page, u8 lsp, u8 csi, >> static struct nvme_cel *nvme_find_cel(struct nvme_ctrl *ctrl, u8 csi)

Re: [RESEND PATCH] nvme: Use spin_lock_irqsave() when taking the ctrl->lock

2020-08-12 Thread Keith Busch
On Wed, Aug 12, 2020 at 03:01:19PM -0600, Logan Gunthorpe wrote: > @@ -2971,15 +2971,16 @@ int nvme_get_log(struct nvme_ctrl *ctrl, u32 nsid, u8 > log_page, u8 lsp, u8 csi, > static struct nvme_cel *nvme_find_cel(struct nvme_ctrl *ctrl, u8 csi) > { > struct nvme_cel *cel, *ret = NULL; > +

[RESEND PATCH] nvme: Use spin_lock_irqsave() when taking the ctrl->lock

2020-08-12 Thread Logan Gunthorpe
When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a dead lock. The new spin_lock() calls recently added produce the following lockdep warning when running the blktest nvme/003: WARNING: inconsistent lock state

[PATCH] nvme: Use spin_lock_irqsave() when taking the ctrl->lock

2020-07-29 Thread Logan Gunthorpe
When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a dead lock. The new spin_lock() calls recently added produce the following lockdep warning when running the blktest nvme/003: WARNING: inconsistent lock state