Re: [PATCH] nvme: do not call del_gendisk() on a disk that was never added

2020-06-09 Thread Christoph Hellwig
Thanks, applied to nvme-5.8.

Re: [PATCH] nvme: do not call del_gendisk() on a disk that was never added

2020-06-07 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH] nvme: do not call del_gendisk() on a disk that was never added

2020-06-07 Thread Max Gurtovoy
On 6/7/2020 2:45 PM, Niklas Cassel wrote: device_add_disk() is negated by del_gendisk(). alloc_disk_node() is negated by put_disk(). In nvme_alloc_ns(), device_add_disk() is one of the last things being called in the success case, and only void functions are being called after this. Therefore

[PATCH] nvme: do not call del_gendisk() on a disk that was never added

2020-06-07 Thread Niklas Cassel
device_add_disk() is negated by del_gendisk(). alloc_disk_node() is negated by put_disk(). In nvme_alloc_ns(), device_add_disk() is one of the last things being called in the success case, and only void functions are being called after this. Therefore this call should not be negated in the error p