Re: [PATCH] test/nvme/003: add test case for patch "nvme: don't send keep-alives to the discovery controller"

On Tue, Mar 27, 2018 at 11:31:47AM +0200, Johannes Thumshirn wrote: > Add a regression test for the patch titled "nvme: don't send > keep-alives to the discovery controller". > > This patch creates a local loopback nvme target and then connects to > it. If the patch is not applied we see two error

Re: [PATCH] nvme: don't send keep-alives to the discovery controller

Thanks, applied.

Re: [PATCH] nvme: don't send keep-alives to the discovery controller

Looks good, Reviewed-by: Christoph Hellwig

[PATCH] test/nvme/003: add test case for patch "nvme: don't send keep-alives to the discovery controller"

3 insertions(+) create mode 100755 tests/nvme/003 create mode 100644 tests/nvme/003.out diff --git a/tests/nvme/003 b/tests/nvme/003 new file mode 100755 index ..5353de5ae9c3 --- /dev/null +++ b/tests/nvme/003 @@ -0,0 +1,61 @@ +#!/bin/bash +# +# Regression test for patch "nvme:

[PATCH] nvme: don't send keep-alives to the discovery controller

NVMe over Fabrics 1.0 Section 5.2 "Discovery Controller Properties and Command Support" Figure 31 "Discovery Controller – Admin Commands" explicitly listst all commands but "Get Log Page" and "Identify" as reserved, but NetApp report the Linux host is sending Keep Alive commands to the discovery co