[PATCH] nvme: fix doulbe irq free

2020-09-16 Thread Tong Zhang
the irq might already been released before reset work can run [ 81.137630] [ cut here ] [ 81.137913] Trying to free already-free IRQ 11 [ 81.138145] WARNING: CPU: 1 PID: 7 at kernel/irq/manage.c:1751 free_irq+0x389/0x590 [ 81.138525] Modules linked in: [ 81.13868

Re: [PATCH] nvme: fix doulbe irq free

2020-09-17 Thread Christoph Hellwig
On Wed, Sep 16, 2020 at 11:37:00AM -0400, Tong Zhang wrote: > the irq might already been released before reset work can run If it is we have a problem with the state machine, as we shouldn't have two resets running at the same time. Can you share your reproducer?

Re: [PATCH] nvme: fix doulbe irq free

2020-09-17 Thread Keith Busch
On Thu, Sep 17, 2020 at 11:22:54AM -0400, Tong Zhang wrote: > On Thu, Sep 17, 2020 at 4:30 AM Christoph Hellwig wrote: > > > > On Wed, Sep 16, 2020 at 11:37:00AM -0400, Tong Zhang wrote: > > > the irq might already been released before reset work can run > > > > If it is we have a problem with the

Re: [PATCH] nvme: fix doulbe irq free

2020-09-17 Thread Tong Zhang
On Thu, Sep 17, 2020 at 4:30 AM Christoph Hellwig wrote: > > On Wed, Sep 16, 2020 at 11:37:00AM -0400, Tong Zhang wrote: > > the irq might already been released before reset work can run > > If it is we have a problem with the state machine, as we shouldn't > have two resets running at the same ti