Re: [PATCH] nvme: fix multipath crash when ANA deactivated

2019-07-02 Thread Christoph Hellwig
On Tue, Jul 02, 2019 at 11:52:35AM +0200, Marta Rybczynska wrote: > > They idea was to use a 'ana_log_buf == NULL' as an indicator that ANA is > > disabled, so there is no need to have an additional flag. > > OK, still keeping the split of the helper functions? I think we can simplify switch nvme

Re: [PATCH] nvme: fix multipath crash when ANA deactivated

2019-07-02 Thread Marta Rybczynska
- On 2 Jul, 2019, at 11:31, Hannes Reinecke h...@suse.de wrote: > On 7/1/19 12:10 PM, Marta Rybczynska wrote: >> Fix a crash with multipath activated. It happends when ANA log >> page is larger than MDTS and because of that ANA is disabled. >> When connecting the target, the driver in nvme_par

Re: [PATCH] nvme: fix multipath crash when ANA deactivated

2019-07-02 Thread Hannes Reinecke
On 7/1/19 12:10 PM, Marta Rybczynska wrote: > Fix a crash with multipath activated. It happends when ANA log > page is larger than MDTS and because of that ANA is disabled. > When connecting the target, the driver in nvme_parse_ana_log > then tries to access nvme_mpath_init.ctrl->ana_log_buf that i

[PATCH] nvme: fix multipath crash when ANA deactivated

2019-07-01 Thread Marta Rybczynska
Fix a crash with multipath activated. It happends when ANA log page is larger than MDTS and because of that ANA is disabled. When connecting the target, the driver in nvme_parse_ana_log then tries to access nvme_mpath_init.ctrl->ana_log_buf that is unallocated. The signature is as follows: [ 300.