On Mon, Sep 25, 2017 at 10:23:16AM +0200, Hannes Reinecke wrote:
> > We could have such an interface I assume. But it would suck to maintain
> > yet another state (we are already having enough trouble to have a
> > coherent controller state machine).
>
> Weell ... we could be using a notifier chai
On 09/25/2017 09:09 AM, Sagi Grimberg wrote:
>
>
> On 25/09/17 08:59, Hannes Reinecke wrote:
>> On 09/25/2017 07:37 AM, Sagi Grimberg wrote:
>>>
So why exposing it then in the first time? I know you don't want
dm-mpath in
NVMe (neither do I) but we have to have something until your
On 25/09/17 08:59, Hannes Reinecke wrote:
On 09/25/2017 07:37 AM, Sagi Grimberg wrote:
So why exposing it then in the first time? I know you don't want
dm-mpath in
NVMe (neither do I) but we have to have something until your patchset
and ANA
is merged. And with this patch it's trivial to bui
On 09/25/2017 07:37 AM, Sagi Grimberg wrote:
>
>> So why exposing it then in the first time? I know you don't want
>> dm-mpath in
>> NVMe (neither do I) but we have to have something until your patchset
>> and ANA
>> is merged. And with this patch it's trivial to build a path checker
>> that just
So why exposing it then in the first time? I know you don't want dm-mpath in
NVMe (neither do I) but we have to have something until your patchset and ANA
is merged. And with this patch it's trivial to build a path checker that just
looks at the state attribute in sysfs.
Can't we just not use
Notify sysfs about changes of a nvme controller so user-space can watch the
file via poll() or select() in order to react to a state change.
Userspace has no business polling for the state.
Please consider this patch. At least upstream multipath-tools is using the
sysfs state now:
[1]
htt
On Thu, Sep 21, 2017 at 07:19:15AM +0200, Johannes Thumshirn wrote:
> So why exposing it then in the first time?
It is a really nice debug aid, but the states really are an internal
detail of the implementation, and can (and probably will soon, see the
fc states discussion) change.
Maybe we need
On 2017/9/20 22:59, Christoph Hellwig wrote:
> On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote:
>> Notify sysfs about changes of a nvme controller so user-space can watch the
>> file via poll() or select() in order to react to a state change.
>
> Userspace has no business poll
On Wed, Sep 20, 2017 at 04:59:31PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote:
> > Notify sysfs about changes of a nvme controller so user-space can watch the
> > file via poll() or select() in order to react to a state change.
>
> Userspac
On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote:
> Notify sysfs about changes of a nvme controller so user-space can watch the
> file via poll() or select() in order to react to a state change.
Userspace has no business polling for the state.
Looks good,
Reviewed-by: Sagi Grimberg
Notify sysfs about changes of a nvme controller so user-space can watch the
file via poll() or select() in order to react to a state change.
Signed-off-by: Johannes Thumshirn
---
drivers/nvme/host/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/cor
12 matches
Mail list logo
