Re: [PATCH] nvme: use upper_32_bits() instead of bit shift

On Wed, Mar 28, 2018 at 03:57:47PM +0200, Arnd Bergmann wrote: > @@ -2233,8 +2233,8 @@ int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct > nvme_ns *ns, > c.get_log_page.lid = log_page; > c.get_log_page.numdl = cpu_to_le16(dwlen & ((1 << 16) - 1)); > c.get_log_page.numdu =

Re: [PATCH] nvme: use upper_32_bits() instead of bit shift

On Wed, Mar 28, 2018 at 03:57:47PM +0200, Arnd Bergmann wrote: > @@ -2233,8 +2233,8 @@ int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct > nvme_ns *ns, > c.get_log_page.lid = log_page; > c.get_log_page.numdl = cpu_to_le16(dwlen & ((1 << 16) - 1)); > c.get_log_page.numdu =

Re: [PATCH] nvme: use upper_32_bits() instead of bit shift

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] nvme: use upper_32_bits() instead of bit shift

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH] nvme: use upper_32_bits() instead of bit shift

On 32-bit architectures, we cannot shift a size_t by 32 bits to the right without a compiler warning: drivers/nvme/host/core.c: In function 'nvme_get_log_ext': drivers/nvme/host/core.c:2237:43: error: right shift count >= width of type [-Werror=shift-count-overflow] c.get_log_page.lpou =

[PATCH] nvme: use upper_32_bits() instead of bit shift

On 32-bit architectures, we cannot shift a size_t by 32 bits to the right without a compiler warning: drivers/nvme/host/core.c: In function 'nvme_get_log_ext': drivers/nvme/host/core.c:2237:43: error: right shift count >= width of type [-Werror=shift-count-overflow] c.get_log_page.lpou =