Re: [PATCH] nvme-fabrics: remove some logically dead code performing redundant ret checks

2016-12-19 Thread James Smart
Looks good. -- james Signed-off-by: James Smart On 12/9/2016 6:59 AM, Colin King wrote: From: Colin Ian King The check to see if ret is non-zero and return this rather than count is redundant in two occassions. It is redundant because

Re: [PATCH] nvme-fabrics: remove some logically dead code performing redundant ret checks

2016-12-19 Thread James Smart
Looks good. -- james Signed-off-by: James Smart On 12/9/2016 6:59 AM, Colin King wrote: From: Colin Ian King The check to see if ret is non-zero and return this rather than count is redundant in two occassions. It is redundant because prior to this check, the return code ret is already

[PATCH] nvme-fabrics: remove some logically dead code performing redundant ret checks

2016-12-09 Thread Colin King
From: Colin Ian King The check to see if ret is non-zero and return this rather than count is redundant in two occassions. It is redundant because prior to this check, the return code ret is already checked for a non-zero error return value and we return from the

[PATCH] nvme-fabrics: remove some logically dead code performing redundant ret checks

2016-12-09 Thread Colin King
From: Colin Ian King The check to see if ret is non-zero and return this rather than count is redundant in two occassions. It is redundant because prior to this check, the return code ret is already checked for a non-zero error return value and we return from the function at that point.