Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-28 Thread Tong Zhang
Hi Keith, Thanks for the confirmation. I will send another revision according to your comments. Best, - Tong On Thu, Aug 27, 2020 at 11:01 AM Keith Busch wrote: > > On Fri, Aug 14, 2020 at 12:11:56PM -0400, Tong Zhang wrote: > > On Fri, Aug 14, 2020 at 11:42 AM Keith Busch wrote: > > > > > On

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-27 Thread Keith Busch
On Fri, Aug 14, 2020 at 12:11:56PM -0400, Tong Zhang wrote: > On Fri, Aug 14, 2020 at 11:42 AM Keith Busch wrote: > > > > On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > > > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > > > index ba725ae47305..c4f1ce0ee1e3

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Sagi Grimberg
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index ba725ae47305..c4f1ce0ee1e3 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1249,8 +1249,8 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Tong Zhang
On Fri, Aug 14, 2020 at 11:42 AM Keith Busch wrote: > > > On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > > index ba725ae47305..c4f1ce0ee1e3 100644 > > > > --- a/drivers/nvme/host/pci.c > > > > +++

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Keith Busch
On Fri, Aug 14, 2020 at 11:37:20AM -0400, Tong Zhang wrote: > On Fri, Aug 14, 2020 at 11:04 AM Keith Busch wrote: > > > > On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > index ba725ae47305..c4f1ce0ee1e3 100644

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Tong Zhang
Hi Keith, On Fri, Aug 14, 2020 at 11:04 AM Keith Busch wrote: > > On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > index ba725ae47305..c4f1ce0ee1e3 100644 > > --- a/drivers/nvme/host/pci.c > > +++

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Keith Busch
On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index ba725ae47305..c4f1ce0ee1e3 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -1249,8 +1249,8 @@ static enum blk_eh_timer_return

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Tong Zhang
Oops sorry for the duplicated email -- I forgot to turn off HTML when sending the previous one. Thanks Christoph, I did a couple of fixes on the commit log, please see v2 patch. Thanks! -- Tong On Fri, Aug 14, 2020 at 4:16 AM Christoph Hellwig wrote: > > On Fri, Aug 14, 2020 at 03:14:31AM

Re: [PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Christoph Hellwig
On Fri, Aug 14, 2020 at 03:14:31AM -0400, Tong Zhang wrote: > This patch addresses an irq free warning and null pointer dereference > error problem when nvme devices got timeout error during initialization. > This problem happens when nvme_timeout() function is called while >

[PATCH] nvme-pci: cancel nvme device request before disabling

2020-08-14 Thread Tong Zhang
This patch addresses an irq free warning and null pointer dereference error problem when nvme devices got timeout error during initialization. This problem happens when nvme_timeout() function is called while nvme_reset_work() is still in execution. This patch fixed the problem by