Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2020-08-04 Thread Gaurav Kohli
Please ignore this patch also, sent due to git send mistake. Apologies for the spam. On 8/4/2020 7:44 PM, Gaurav Kohli wrote: From: Srinivas Kandagatla Many nvmem providers are not very keen on having default sysfs nvmem entry, as most of the usecases for them are inside kernel itself. And

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Mika Westerberg
On Tue, Apr 16, 2019 at 10:44:01AM +0100, Srinivas Kandagatla wrote: > As Kohli suggested we could make NVMEM_SYSFS default to y so that the sysfs > file is available by default like before and user/board specific can decide > to deselect it. > > Let me know if thats Okay with you, I can spin

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Srinivas Kandagatla
On 16/04/2019 10:34, Mika Westerberg wrote: On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote: Hi Srinivas, Thanks for the patch, By default NVMEM_SYSFS should be set true, those whose don't want they can disable the same. If we go with disable option, there are chances of

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-16 Thread Mika Westerberg
On Tue, Apr 16, 2019 at 10:49:22AM +0530, Gaurav Kohli wrote: > Hi Srinivas, > > Thanks for the patch, > By default NVMEM_SYSFS should be set true, those whose don't want they can > disable the same. > > If we go with disable option, there are chances of eeprom may break in below > case: > > if

Re: [PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-15 Thread Gaurav Kohli
Hi Srinivas, Thanks for the patch, By default NVMEM_SYSFS should be set true, those whose don't want they can disable the same. If we go with disable option, there are chances of eeprom may break in below case: if (config->compat) { rval = nvmem_sysfs_setup_compat(nvmem,

[PATCH] nvmem: core: add NVMEM_SYSFS Kconfig

2019-04-15 Thread Srinivas Kandagatla
Many nvmem providers are not very keen on having default sysfs nvmem entry, as most of the usecases for them are inside kernel itself. And in some cases read/writes to some areas in nvmem are restricted and trapped at secure monitor level, so accessing them from userspace would result in board