Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
On Wed, Jun 08, 2016 at 07:52:06PM +0100, Srinivas Kandagatla wrote: > On 08/06/16 17:40, Brian Norris wrote: > >On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > >>With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > >>it returns char *. Let's make that

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
On Wed, Jun 08, 2016 at 07:52:06PM +0100, Srinivas Kandagatla wrote: > On 08/06/16 17:40, Brian Norris wrote: > >On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > >>With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > >>it returns char *. Let's make that

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Srinivas Kandagatla
On 08/06/16 17:40, Brian Norris wrote: On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM it returns char *. Let's make that consistent. Also drop the incorrect/inconsistent comment about char * above the

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Srinivas Kandagatla
On 08/06/16 17:40, Brian Norris wrote: On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM it returns char *. Let's make that consistent. Also drop the incorrect/inconsistent comment about char * above the

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 09:40:11AM -0700, Brian Norris wrote: > On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > > it returns char *. Let's make that consistent. Also drop the > > incorrect/inconsistent

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Guenter Roeck
On Wed, Jun 08, 2016 at 09:40:11AM -0700, Brian Norris wrote: > On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > > it returns char *. Let's make that consistent. Also drop the > > incorrect/inconsistent

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > it returns char *. Let's make that consistent. Also drop the > incorrect/inconsistent comment about char * above the nvmem_cell_read() > definition. > >

Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > it returns char *. Let's make that consistent. Also drop the > incorrect/inconsistent comment about char * above the nvmem_cell_read() > definition. > >

[PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM it returns char *. Let's make that consistent. Also drop the incorrect/inconsistent comment about char * above the nvmem_cell_read() definition. drivers/thermal/mtk_thermal.c is already working around this by casting to (u32

[PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

2016-06-08 Thread Brian Norris
With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM it returns char *. Let's make that consistent. Also drop the incorrect/inconsistent comment about char * above the nvmem_cell_read() definition. drivers/thermal/mtk_thermal.c is already working around this by casting to (u32