Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 09:30:18AM +0100, Peter Zijlstra wrote: > On Thu, Mar 18, 2021 at 08:59:45AM +0100, Peter Zijlstra wrote: > > On Wed, Mar 17, 2021 at 07:02:12PM -0500, Josh Poimboeuf wrote: > > > On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > > > > arguably it simply

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 08:59:45AM +0100, Peter Zijlstra wrote: > On Wed, Mar 17, 2021 at 07:02:12PM -0500, Josh Poimboeuf wrote: > > On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > > > arguably it simply isn't a good idea to use static_call() in __exit > > > code anyway, since

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-18 Thread Peter Zijlstra
On Wed, Mar 17, 2021 at 07:02:12PM -0500, Josh Poimboeuf wrote: > On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > > arguably it simply isn't a good idea to use static_call() in __exit > > code anyway, since module unload is never a performance critical path. > > Couldn't you

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Sumit Garg
On Thu, 18 Mar 2021 at 03:26, Jarkko Sakkinen wrote: > > On Wed, Mar 17, 2021 at 07:07:07PM +0530, Sumit Garg wrote: > > On Wed, 17 Mar 2021 at 18:16, Peter Zijlstra wrote: > > > > > > On Wed, Mar 17, 2021 at 05:25:48PM +0530, Sumit Garg wrote: > > > > Thanks Peter for this fix. It does work for

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Josh Poimboeuf
On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > arguably it simply isn't a good idea to use static_call() in __exit > code anyway, since module unload is never a performance critical path. Couldn't you make the same argument about __init functions, which are allowed to do static

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Jarkko Sakkinen
On Wed, Mar 17, 2021 at 07:07:07PM +0530, Sumit Garg wrote: > On Wed, 17 Mar 2021 at 18:16, Peter Zijlstra wrote: > > > > On Wed, Mar 17, 2021 at 05:25:48PM +0530, Sumit Garg wrote: > > > Thanks Peter for this fix. It does work for me on qemu for x86. Can > > > you turn this into a proper fix

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Jarkko Sakkinen
On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > On Wed, Mar 17, 2021 at 05:25:48PM +0530, Sumit Garg wrote: > > Thanks Peter for this fix. It does work for me on qemu for x86. Can > > you turn this into a proper fix patch? BTW, feel free to add: > > Per the below, the original

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Sumit Garg
On Wed, 17 Mar 2021 at 18:16, Peter Zijlstra wrote: > > On Wed, Mar 17, 2021 at 05:25:48PM +0530, Sumit Garg wrote: > > Thanks Peter for this fix. It does work for me on qemu for x86. Can > > you turn this into a proper fix patch? BTW, feel free to add: > > Per the below, the original patch ought

[PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-17 Thread Peter Zijlstra
On Wed, Mar 17, 2021 at 05:25:48PM +0530, Sumit Garg wrote: > Thanks Peter for this fix. It does work for me on qemu for x86. Can > you turn this into a proper fix patch? BTW, feel free to add: Per the below, the original patch ought to be fixed as well, to not use static_call() in __exit. ---