[PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-27 Thread peterz
Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to anything. Signed-off-by: Peter Zijlstra (Intel) --- tools/objtool/check.c |8 1 file changed, 8 insertions(+) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -551,6 +551,14 @@ static const char *uac

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-28 Thread peterz
On Mon, Jul 27, 2020 at 10:56:03PM +0200, Thomas Gleixner wrote: > pet...@infradead.org writes: > > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > > anything. > > Yuck. Isn't that what noinstr is for or am I missing something? Well, we don't want poke_int3_handler() to c

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-27 Thread Ingo Molnar
* pet...@infradead.org wrote: > > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > anything. > > Signed-off-by: Peter Zijlstra (Intel) > --- > tools/objtool/check.c |8 > 1 file changed, 8 insertions(+) > > --- a/tools/objtool/check.c > +++ b/tools/objt

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-27 Thread peterz
On Mon, Jul 27, 2020 at 01:21:44PM +0200, Ingo Molnar wrote: > > * pet...@infradead.org wrote: > > > > > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > > anything. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > > tools/objtool/check.c |8 > > 1

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-27 Thread Ingo Molnar
* pet...@infradead.org wrote: > On Mon, Jul 27, 2020 at 01:21:44PM +0200, Ingo Molnar wrote: > > > > * pet...@infradead.org wrote: > > > > > > > > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > > > anything. > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > >

Re: [PATCH] objtool,x86: Verify poke_int3_handler() is self contained

2020-07-27 Thread Thomas Gleixner
pet...@infradead.org writes: > Abuse the SMAP rules to ensure poke_int3_handler() doesn't call out to > anything. Yuck. Isn't that what noinstr is for or am I missing something? Thanks, tglx