Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Andrew. Is there problem this patch to merge? If you care about mlog_errno() cleanup, I will send another patch for that. And also if you have any reasons this patch has not been taken, please let me know. I will fix and test again. Thanks. regards, Daeseok Youn/ 2015-04-23 9:49 GMT+09:00

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Andrew. Is there problem this patch to merge? If you care about mlog_errno() cleanup, I will send another patch for that. And also if you have any reasons this patch has not been taken, please let me know. I will fix and test again. Thanks. regards, Daeseok Youn/ 2015-04-23 9:49 GMT+09:00

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Joseph. 2015-04-23 9:49 GMT+09:00 Joseph Qi : > On 2015/4/19 13:43, Daeseok Youn wrote: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> value. Some functions' return value in __ocfs2_add_entry(), >> i.e ocfs2_journal_access_di() is saved to 'status'. >> But 'status' is not

Re: [PATCH] ocfs2: use retval instead of status for checking error

On 2015/4/19 13:43, Daeseok Youn wrote: > The use of 'status' in __ocfs2_add_entry() can return wrong > value. Some functions' return value in __ocfs2_add_entry(), > i.e ocfs2_journal_access_di() is saved to 'status'. > But 'status' is not used in 'bail' label for returning result > of

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Joseph. 2015-04-23 9:49 GMT+09:00 Joseph Qi joseph...@huawei.com: On 2015/4/19 13:43, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But

Re: [PATCH] ocfs2: use retval instead of status for checking error

On 2015/4/19 13:43, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label for returning result of

[PATCH] ocfs2: use retval instead of status for checking error

The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label for returning result of __ocfs2_add_entry(). So use retval instead of status.

[PATCH] ocfs2: use retval instead of status for checking error

The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label for returning result of __ocfs2_add_entry(). So use retval instead of status.