Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 21:52 -0700, Grant Likely wrote: > Thinking about this more, I'd like to suggest a different format that > gives us a nice hack on the name that makes it easy to remember: > '%pOF[...]' > 'O' still means 'object', but it is also overloaded for Open Firmware. > That

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Grant Likely
On Tue, 31 Mar 2015 13:03:05 +0300 , Pantelis Antoniou wrote: > > +Device tree nodes: > > + > > + %pOn[fnpPcCFr] > > + > > + For printing device tree nodes. The optional arguments are: > > + f device node full_name > > + n device node name > > + p device node phandle > > +

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Pantelis Antoniou
Hi Grant, > On Mar 31, 2015, at 20:02 , Grant Likely wrote: > > Hi Pantelis, > > Thanks for the quick reply. Comments below... > > On Tue, 31 Mar 2015 13:03:05 +0300 > , Pantelis Antoniou > wrote: >> Hi Grant, >> >>> On Mar 30, 2015, at 22:04 , Grant Likely wrote: >>> >>> On Thu, 22 Jan

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Grant Likely
Hi Pantelis, Thanks for the quick reply. Comments below... On Tue, 31 Mar 2015 13:03:05 +0300 , Pantelis Antoniou wrote: > Hi Grant, > > > On Mar 30, 2015, at 22:04 , Grant Likely wrote: > > > > On Thu, 22 Jan 2015 22:31:46 +0200 > > , Pantelis Antoniou > > wrote: > >> Hi Joe, > >> > >>>

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Pantelis Antoniou
Hi Grant, > On Mar 30, 2015, at 22:04 , Grant Likely wrote: > > On Thu, 22 Jan 2015 22:31:46 +0200 > , Pantelis Antoniou > wrote: >> Hi Joe, >> >>> On Jan 21, 2015, at 19:37 , Joe Perches wrote: >>> >>> On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Pantelis Antoniou
Hi Grant, On Mar 30, 2015, at 22:04 , Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 22 Jan 2015 22:31:46 +0200 , Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200,

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 21:52 -0700, Grant Likely wrote: Thinking about this more, I'd like to suggest a different format that gives us a nice hack on the name that makes it easy to remember: '%pOF[...]' 'O' still means 'object', but it is also overloaded for Open Firmware. That still

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Grant Likely
On Tue, 31 Mar 2015 13:03:05 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: +Device tree nodes: + + %pOn[fnpPcCFr] + + For printing device tree nodes. The optional arguments are: + f device node full_name + n device node name + p device node

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Grant Likely
Hi Pantelis, Thanks for the quick reply. Comments below... On Tue, 31 Mar 2015 13:03:05 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Grant, On Mar 30, 2015, at 22:04 , Grant Likely grant.lik...@secretlab.ca wrote: On Thu, 22 Jan 2015 22:31:46 +0200 , Pantelis

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-31 Thread Pantelis Antoniou
Hi Grant, On Mar 31, 2015, at 20:02 , Grant Likely grant.lik...@secretlab.ca wrote: Hi Pantelis, Thanks for the quick reply. Comments below... On Tue, 31 Mar 2015 13:03:05 +0300 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Grant, On Mar 30, 2015, at 22:04 , Grant

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-30 Thread Grant Likely
On Thu, 22 Jan 2015 22:31:46 +0200 , Pantelis Antoniou wrote: > Hi Joe, > > > On Jan 21, 2015, at 19:37 , Joe Perches wrote: > > > > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: > >> 90% of the usage of device node's full_name is printing it out > >> in a kernel message.

Re: [PATCH] of: Custom printk format specifier for device node

2015-03-30 Thread Grant Likely
On Thu, 22 Jan 2015 22:31:46 +0200 , Pantelis Antoniou pa...@antoniou-consulting.com wrote: Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-22 Thread Pantelis Antoniou
Hi Joe, > On Jan 21, 2015, at 19:37 , Joe Perches wrote: > > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: >> 90% of the usage of device node's full_name is printing it out >> in a kernel message. Preparing for the eventual delayed allocation >> introduce a custom printk format

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-22 Thread Pantelis Antoniou
Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Måns Rullgård
Pantelis Antoniou writes: > Hi Joe, > >> On Jan 21, 2015, at 19:37 , Joe Perches wrote: >> >> On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: >>> 90% of the usage of device node's full_name is printing it out >>> in a kernel message. Preparing for the eventual delayed allocation

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Joe Perches
On Wed, 2015-01-21 at 19:39 +0200, Pantelis Antoniou wrote: > Hi Joe, > > > On Jan 21, 2015, at 19:37 , Joe Perches wrote: > > > > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: > >> 90% of the usage of device node's full_name is printing it out > >> in a kernel message. Preparing

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Pantelis Antoniou
Hi Joe, > On Jan 21, 2015, at 19:37 , Joe Perches wrote: > > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: >> 90% of the usage of device node's full_name is printing it out >> in a kernel message. Preparing for the eventual delayed allocation >> introduce a custom printk format

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Joe Perches
On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: > 90% of the usage of device node's full_name is printing it out > in a kernel message. Preparing for the eventual delayed allocation > introduce a custom printk format specifier that is both more > compact and more pleasant to the eye. >

[PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Pantelis Antoniou
90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For instance typical use is: pr_info("Frobbing node %s\n",

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Joe Perches
On Wed, 2015-01-21 at 19:39 +0200, Pantelis Antoniou wrote: Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it out in a kernel message.

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Pantelis Antoniou
Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Måns Rullgård
Pantelis Antoniou pa...@antoniou-consulting.com writes: Hi Joe, On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote: On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Joe Perches
On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye.

[PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Pantelis Antoniou
90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For instance typical use is: pr_info(Frobbing node %s\n,

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Joe Perches
On Tue, 2015-01-20 at 20:06 +0200, Pantelis Antoniou wrote: > On Jan 20, 2015, at 19:59 , Joe Perches wrote: > > On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: > >>> On Jan 20, 2015, at 16:47 , Rob Herring wrote: > >>> On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou > >>> wrote:

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Joe, > On Jan 20, 2015, at 19:59 , Joe Perches wrote: > > On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: >> Hi Rob, >> >>> On Jan 20, 2015, at 16:47 , Rob Herring wrote: >>> >>> On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou >>> wrote: 90% of the usage of device

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Joe Perches
On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: > Hi Rob, > > > On Jan 20, 2015, at 16:47 , Rob Herring wrote: > > > > On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou > > wrote: > >> 90% of the usage of device node's full_name is printing it out > >> in a kernel message.

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 10:05 AM, Måns Rullgård wrote: > Pantelis Antoniou writes: > >> Hi Geert, >> >>> On Jan 20, 2015, at 17:24 , Geert Uytterhoeven wrote: >>> >>> On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring wrote: > + Examples: > + > + %pO /foo/bar@0

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Måns Rullgård
Pantelis Antoniou writes: > Hi Geert, > >> On Jan 20, 2015, at 17:24 , Geert Uytterhoeven wrote: >> >> On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring wrote: + Examples: + + %pO /foo/bar@0 - Node full name + %pO0/foo/bar@0 -

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Geert, > On Jan 20, 2015, at 17:24 , Geert Uytterhoeven wrote: > > On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring wrote: >>> + Examples: >>> + >>> + %pO /foo/bar@0 - Node full name >>> + %pO0/foo/bar@0 - Same as above >>> + %pO1

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Geert Uytterhoeven
On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring wrote: >> + Examples: >> + >> + %pO /foo/bar@0 - Node full name >> + %pO0/foo/bar@0 - Same as above >> + %pO1/foo/bar@0[10] - Node full name + phandle >> + %pO2

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Rob, > On Jan 20, 2015, at 16:47 , Rob Herring wrote: > > On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou > wrote: >> 90% of the usage of device node's full_name is printing it out >> in a kernel message. Preparing for the eventual delayed allocation >> introduce a custom printk format

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou wrote: > 90% of the usage of device node's full_name is printing it out > in a kernel message. Preparing for the eventual delayed allocation > introduce a custom printk format specifier that is both more > compact and more pleasant to the eye.

[PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For instance typical use is: pr_info("Frobbing node %s\n",

[PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For instance typical use is: pr_info(Frobbing node %s\n,

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Rob, On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote: On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 10:05 AM, Måns Rullgård m...@mansr.com wrote: Pantelis Antoniou pantelis.anton...@konsulko.com writes: Hi Geert, On Jan 20, 2015, at 17:24 , Geert Uytterhoeven ge...@linux-m68k.org wrote: On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring robherri...@gmail.com wrote: +

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Geert, On Jan 20, 2015, at 17:24 , Geert Uytterhoeven ge...@linux-m68k.org wrote: On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring robherri...@gmail.com wrote: + Examples: + + %pO /foo/bar@0 - Node full name + %pO0/foo/bar@0 - Same as

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Måns Rullgård
Pantelis Antoniou pantelis.anton...@konsulko.com writes: Hi Geert, On Jan 20, 2015, at 17:24 , Geert Uytterhoeven ge...@linux-m68k.org wrote: On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring robherri...@gmail.com wrote: + Examples: + + %pO /foo/bar@0 - Node full

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Geert Uytterhoeven
On Tue, Jan 20, 2015 at 3:47 PM, Rob Herring robherri...@gmail.com wrote: + Examples: + + %pO /foo/bar@0 - Node full name + %pO0/foo/bar@0 - Same as above + %pO1/foo/bar@0[10] - Node full name + phandle + %pO2

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Joe Perches
On Tue, 2015-01-20 at 20:06 +0200, Pantelis Antoniou wrote: On Jan 20, 2015, at 19:59 , Joe Perches j...@perches.com wrote: On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote: On Tue, Jan 20, 2015 at 8:34 AM,

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Pantelis Antoniou
Hi Joe, On Jan 20, 2015, at 19:59 , Joe Perches j...@perches.com wrote: On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: Hi Rob, On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote: On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Joe Perches
On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote: Hi Rob, On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote: On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: 90% of the usage of device node's full_name is printing it