Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-10 Thread Robin Murphy
On 07/04/17 18:09, Rob Herring wrote: > + Robin, Sricharan > > On Fri, Apr 7, 2017 at 12:18 AM, Frank Rowand wrote: >> On 04/06/17 15:41, Rob Herring wrote: >>> On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand wrote: On 04/06/17 07:03, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:18 AM,

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-10 Thread Frank Rowand
On 04/10/17 04:48, Sricharan R wrote: > Hi Frank, > > > Can we get back to the basic premise of the proposed patch? The current code in of_dma_configure() contains a hack that allows the dma-ranges property to specify a mask instead of a size. The binding in the specifi

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-10 Thread Sricharan R
Hi Frank, Can we get back to the basic premise of the proposed patch? The current code in of_dma_configure() contains a hack that allows the dma-ranges property to specify a mask instead of a size. The binding in the specification allows a size and does not allow a mask. The hack was added

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-07 Thread Frank Rowand
On 04/07/17 10:09, Rob Herring wrote: > + Robin, Sricharan > > On Fri, Apr 7, 2017 at 12:18 AM, Frank Rowand wrote: >> On 04/06/17 15:41, Rob Herring wrote: >>> On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand wrote: On 04/06/17 07:03, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:18 AM,

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-07 Thread Rob Herring
+ Robin, Sricharan On Fri, Apr 7, 2017 at 12:18 AM, Frank Rowand wrote: > On 04/06/17 15:41, Rob Herring wrote: >> On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand wrote: >>> On 04/06/17 07:03, Rob Herring wrote: On Thu, Apr 6, 2017 at 1:18 AM, wrote: > From: Frank Rowand > > of_

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Frank Rowand
On 04/06/17 15:41, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand wrote: >> On 04/06/17 07:03, Rob Herring wrote: >>> On Thu, Apr 6, 2017 at 1:18 AM, wrote: From: Frank Rowand of_dma_get_range() has workaround code to fixup a device tree that incorrectly s

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Rob Herring
On Thu, Apr 6, 2017 at 1:37 PM, Frank Rowand wrote: > On 04/06/17 07:03, Rob Herring wrote: >> On Thu, Apr 6, 2017 at 1:18 AM, wrote: >>> From: Frank Rowand >>> >>> of_dma_get_range() has workaround code to fixup a device tree that >>> incorrectly specified a mask instead of a size for property

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Frank Rowand
On 04/06/17 07:03, Rob Herring wrote: > On Thu, Apr 6, 2017 at 1:18 AM, wrote: >> From: Frank Rowand >> >> of_dma_get_range() has workaround code to fixup a device tree that >> incorrectly specified a mask instead of a size for property >> dma-ranges. That device tree was fixed a year ago in v4

Re: [PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread Rob Herring
On Thu, Apr 6, 2017 at 1:18 AM, wrote: > From: Frank Rowand > > of_dma_get_range() has workaround code to fixup a device tree that > incorrectly specified a mask instead of a size for property > dma-ranges. That device tree was fixed a year ago in v4.6, so > the workaround is no longer needed.

[PATCH] of: change fixup of dma-ranges size to error

2017-04-05 Thread frowand . list
From: Frank Rowand of_dma_get_range() has workaround code to fixup a device tree that incorrectly specified a mask instead of a size for property dma-ranges. That device tree was fixed a year ago in v4.6, so the workaround is no longer needed. Leave a data validation check in place, but no long