Re: [PATCH] of: drop a reference on error in __of_attach_node_sysfs()

2020-05-20 Thread Michael Ellerman
Dan Carpenter writes: > We add a new of_node_get() to this function, but we should drop the > reference if kobject_add(). ^ fails? > > Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in > __of_attach_node_sysfs") >

[PATCH] of: drop a reference on error in __of_attach_node_sysfs()

2020-05-18 Thread Dan Carpenter
We add a new of_node_get() to this function, but we should drop the reference if kobject_add(). Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs") Signed-off-by: Dan Carpenter --- >From static analysis. Maybe we should just call of_node_get() right before