Re:Re: [PATCH] of: irq: Add a helper function for irq_of_parse_and_map

2018-07-24 Thread liuxiang
I found in probe function some drivers use irq_of_parse_and_map and do not call irq_dispose_mapping in err path, while other drivers do. So I think a resource managed irq_of_parse_and_map function can be better to finish this job. At 2018-07-23 23:28:52, "Rob Herring" wrote: >On Sat, Jul 21, 20

Re: [PATCH] of: irq: Add a helper function for irq_of_parse_and_map

2018-07-23 Thread Rob Herring
On Sat, Jul 21, 2018 at 9:38 AM Liu Xiang wrote: > > Implement a resource managed irq_of_parse_and_map function. That is obvious from the diff. Why do you need this? Anything that is a platform device should use platform_get_irq. The mapping is created by the core Also, of_irq_get() is preferred

[PATCH] of: irq: Add a helper function for irq_of_parse_and_map

2018-07-20 Thread Liu Xiang
Implement a resource managed irq_of_parse_and_map function. Signed-off-by: Liu Xiang --- drivers/of/irq.c | 38 ++ include/linux/of_irq.h | 7 +++ 2 files changed, 45 insertions(+) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 02ad93a..947