Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Andrew Lunn
> > More worrying, barebox does not support the : either. So there is a > > danger your bootloader suddenly goes silent after a dt blob update. > > Is barebox parsing the property? Or updating it? Or both? I've got no > problem with this patch, but we can also support things like the > 'current-sp

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 15:39 +, Grant Likely wrote: > On Tue, Nov 25, 2014 at 3:24 PM, Ian Campbell wrote: > >> sed s/of_find_node_by_path\((.*)\)/of_find_node_by_path\(\1, NULL\) > > > > Coccinelle rules for this sort of transformation... > > /me still hasn't gotten his head around how to use

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Grant Likely
On Tue, Nov 25, 2014 at 3:24 PM, Ian Campbell wrote: > On Tue, 2014-11-25 at 15:20 +, Grant Likely wrote: >> On Tue, Nov 25, 2014 at 3:15 PM, Leif Lindholm >> wrote: >> > On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: >> >> > + len = strchrnul(path, ':') - path; >> >

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 15:20 +, Grant Likely wrote: > On Tue, Nov 25, 2014 at 3:15 PM, Leif Lindholm > wrote: > > On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: > >> > + len = strchrnul(path, ':') - path; > >> > + > >> > for_each_property_of_node(of_aliases

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Grant Likely
On Tue, Nov 25, 2014 at 3:15 PM, Leif Lindholm wrote: > On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: >> > + len = strchrnul(path, ':') - path; >> > + >> > for_each_property_of_node(of_aliases, pp) { >> > if (strlen(pp->name) == len && !str

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: > > + len = strchrnul(path, ':') - path; > > + > > for_each_property_of_node(of_aliases, pp) { > > if (strlen(pp->name) == len && !strncmp(pp->name, path, > > len)) { > >

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Grant Likely
On Tue, 25 Nov 2014 12:07:29 + , Ian Campbell wrote: > On Tue, 2014-11-25 at 11:17 +, Leif Lindholm wrote: > > On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: > > > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > > > Support specifying console options (lik

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Grant Likely
On Mon, 24 Nov 2014 22:23:58 + , Leif Lindholm wrote: > Support specifying console options (like with console=ttyXN,) > by appending them to the stdout-path property after a separating ':'. > > Example: > stdout-path = "uart0:115200"; > > This patch also modifies of_find_node_by_path(

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Grant Likely
On Tue, 25 Nov 2014 00:00:16 +0100 , Andrew Lunn wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > > > > Example: > > stdout-pat

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
I booted anything at all, given how badly I broke path scanning... Please ignore previous version - a fixed one follows: / Leif >From aef87fd958902afe881720286d525e10997462b8 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Mon, 24 Nov 2014 22:23:58 + Subject: [PATCH] of: support

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Sascha Hauer
On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: > Hi Leif, > > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > > > > Example:

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Ian Campbell
On Tue, 2014-11-25 at 11:17 +, Leif Lindholm wrote: > On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: > > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > > Support specifying console options (like with console=ttyXN,) > > > by appending them to the stdout-path p

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > > > > Example: > > stdout

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Mark Rutland
Hi Leif, On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > Support specifying console options (like with console=ttyXN,) > by appending them to the stdout-path property after a separating ':'. > > Example: > stdout-path = "uart0:115200"; I would very much like to be able to

Re: [PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Sascha Hauer
On Tue, Nov 25, 2014 at 12:00:16AM +0100, Andrew Lunn wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > > > > Example: > > stdout-

Re: [PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 12:00:16AM +0100, Andrew Lunn wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > > > > Example: > > stdout-

Re: [PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Andrew Lunn
On Mon, Nov 24, 2014 at 10:23:58PM +, Leif Lindholm wrote: > Support specifying console options (like with console=ttyXN,) > by appending them to the stdout-path property after a separating ':'. > > Example: > stdout-path = "uart0:115200"; > > This patch also modifies of_find_node_by_pa

[PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Leif Lindholm
Support specifying console options (like with console=ttyXN,) by appending them to the stdout-path property after a separating ':'. Example: stdout-path = "uart0:115200"; This patch also modifies of_find_node_by_path() to match only the portion of the path before a ':'. Signed-off-by: Le