Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-20 Thread David Gibson
On Wed, Jan 20, 2021 at 11:00:17PM -0600, Frank Rowand wrote: > > +David > > so I don't have to repeat this in another thread > > On 1/19/21 11:06 PM, Viresh Kumar wrote: > > On 19-01-21, 09:44, Frank Rowand wrote: > >> No. overlay_base.dts is intentionally compiled into a base FDT, not > >>

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-20 Thread Viresh Kumar
On 20-01-21, 23:00, Frank Rowand wrote: > unittest.c first unflattens overlay_base.dtb during early boot. Then later > it does some phandle resolution using the overlay metadata from overlay_base. > Then it removes the overlay metadata from the in kernel devicetree data > structure. It is a

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-20 Thread Frank Rowand
+David so I don't have to repeat this in another thread On 1/19/21 11:06 PM, Viresh Kumar wrote: > On 19-01-21, 09:44, Frank Rowand wrote: >> No. overlay_base.dts is intentionally compiled into a base FDT, not >> an overlay. Unittest intentionally unflattens this FDT in early boot, >> in

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-19 Thread Viresh Kumar
On 20-01-21, 10:36, Viresh Kumar wrote: > On 19-01-21, 09:44, Frank Rowand wrote: > > No. overlay_base.dts is intentionally compiled into a base FDT, not > > an overlay. Unittest intentionally unflattens this FDT in early boot, > > in association with unflattening the system FDT. One key intent

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-19 Thread Viresh Kumar
On 19-01-21, 09:44, Frank Rowand wrote: > No. overlay_base.dts is intentionally compiled into a base FDT, not > an overlay. Unittest intentionally unflattens this FDT in early boot, > in association with unflattening the system FDT. One key intent > behind this is to use the same memory

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-19 Thread Frank Rowand
On 1/19/21 2:05 AM, Viresh Kumar wrote: > On 18-01-21, 20:21, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> These changes apply on top of the patches in: >> >> [PATCH] of: unittest: Statically apply overlays

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-19 Thread Viresh Kumar
On 18-01-21, 20:21, frowand.l...@gmail.com wrote: > From: Frank Rowand > > These changes apply on top of the patches in: > > [PATCH] of: unittest: Statically apply overlays using fdtoverlay > Message-Id: > <1e42183ccafa1afba33b3e79a4e3efd3329fd133.1610095159.git

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-18 Thread Frank Rowand
On 1/17/21 9:54 PM, Frank Rowand wrote: > Hi Viresh, > > On 1/14/21 11:44 PM, Viresh Kumar wrote: >> +David, >> >> On 14-01-21, 09:01, Rob Herring wrote: >>> On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar >>> wrote: On 11-01-21, 09:46, Rob Herring wrote: > On Fri, Jan 8, 2021 at

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-18 Thread Frank Rowand
On 1/18/21 12:30 AM, David Gibson wrote: > On Fri, Jan 15, 2021 at 11:14:50AM +0530, Viresh Kumar wrote: >> +David, >> >> On 14-01-21, 09:01, Rob Herring wrote: >>> On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar >>> wrote: On 11-01-21, 09:46, Rob Herring wrote: > On Fri, Jan 8, 2021

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-18 Thread Frank Rowand
On 1/13/21 11:00 PM, Viresh Kumar wrote: > Frank/Rob. > > On 08-01-21, 14:11, Viresh Kumar wrote: >> diff --git a/drivers/of/unittest-data/Makefile >> b/drivers/of/unittest-data/Makefile >> index 009f4045c8e4..f17bce85f65f 100644 >> --- a/drivers/of/unittest-data/Makefile >> +++

re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-18 Thread frowand . list
From: Frank Rowand These changes apply on top of the patches in: [PATCH] of: unittest: Statically apply overlays using fdtoverlay Message-Id: <1e42183ccafa1afba33b3e79a4e3efd3329fd133.1610095159.git.viresh.ku...@linaro.org> There are still some issues to be cleaned up, so not

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-17 Thread David Gibson
On Fri, Jan 15, 2021 at 11:14:50AM +0530, Viresh Kumar wrote: > +David, > > On 14-01-21, 09:01, Rob Herring wrote: > > On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar > > wrote: > > > > > > On 11-01-21, 09:46, Rob Herring wrote: > > > > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar > > > > wrote:

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-17 Thread Frank Rowand
Hi Viresh, On 1/14/21 11:44 PM, Viresh Kumar wrote: > +David, > > On 14-01-21, 09:01, Rob Herring wrote: >> On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar >> wrote: >>> >>> On 11-01-21, 09:46, Rob Herring wrote: On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar wrote: > > Now that

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-14 Thread Viresh Kumar
+David, On 14-01-21, 09:01, Rob Herring wrote: > On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar wrote: > > > > On 11-01-21, 09:46, Rob Herring wrote: > > > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar > > > wrote: > > > > > > > > Now that fdtoverlay is part of the kernel build, start using it to

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-14 Thread Rob Herring
On Wed, Jan 13, 2021 at 11:03 PM Viresh Kumar wrote: > > On 11-01-21, 09:46, Rob Herring wrote: > > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar wrote: > > > > > > Now that fdtoverlay is part of the kernel build, start using it to test > > > the unitest overlays we have by applying them

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-13 Thread Viresh Kumar
On 11-01-21, 09:46, Rob Herring wrote: > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar wrote: > > > > Now that fdtoverlay is part of the kernel build, start using it to test > > the unitest overlays we have by applying them statically. > > Nice idea. > > > The file overlay_base.dtb have symbols

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-13 Thread Viresh Kumar
Frank/Rob. On 08-01-21, 14:11, Viresh Kumar wrote: > diff --git a/drivers/of/unittest-data/Makefile > b/drivers/of/unittest-data/Makefile > index 009f4045c8e4..f17bce85f65f 100644 > --- a/drivers/of/unittest-data/Makefile > +++ b/drivers/of/unittest-data/Makefile > @@ -38,3 +38,26 @@

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-13 Thread Frank Rowand
On 1/13/21 9:05 AM, Rob Herring wrote: > On Tue, Jan 12, 2021 at 8:20 PM Frank Rowand wrote: >> >> On 1/12/21 2:46 PM, Rob Herring wrote: >>> On Tue, Jan 12, 2021 at 2:05 PM Frank Rowand wrote: On 1/12/21 1:41 PM, Rob Herring wrote: > On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-13 Thread Rob Herring
On Tue, Jan 12, 2021 at 8:20 PM Frank Rowand wrote: > > On 1/12/21 2:46 PM, Rob Herring wrote: > > On Tue, Jan 12, 2021 at 2:05 PM Frank Rowand wrote: > >> > >> On 1/12/21 1:41 PM, Rob Herring wrote: > >>> On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand > >>> wrote: > > On 1/12/21 8:04

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Frank Rowand
On 1/12/21 2:46 PM, Rob Herring wrote: > On Tue, Jan 12, 2021 at 2:05 PM Frank Rowand wrote: >> >> On 1/12/21 1:41 PM, Rob Herring wrote: >>> On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand wrote: On 1/12/21 8:04 AM, Rob Herring wrote: > On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Frank Rowand
On 1/12/21 1:41 PM, Rob Herring wrote: > On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand wrote: >> >> On 1/12/21 8:04 AM, Rob Herring wrote: >>> On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand wrote: On 1/8/21 2:41 AM, Viresh Kumar wrote: > Now that fdtoverlay is part of the kernel

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Rob Herring
On Tue, Jan 12, 2021 at 2:05 PM Frank Rowand wrote: > > On 1/12/21 1:41 PM, Rob Herring wrote: > > On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand wrote: > >> > >> On 1/12/21 8:04 AM, Rob Herring wrote: > >>> On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand > >>> wrote: > > On 1/8/21 2:41

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Rob Herring
On Tue, Jan 12, 2021 at 1:06 PM Frank Rowand wrote: > > On 1/12/21 8:04 AM, Rob Herring wrote: > > On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand wrote: > >> > >> On 1/8/21 2:41 AM, Viresh Kumar wrote: > >>> Now that fdtoverlay is part of the kernel build, start using it to test > >>> the unitest

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Frank Rowand
On 1/12/21 8:04 AM, Rob Herring wrote: > On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand wrote: >> >> On 1/8/21 2:41 AM, Viresh Kumar wrote: >>> Now that fdtoverlay is part of the kernel build, start using it to test >>> the unitest overlays we have by applying them statically. >>> >>> The file

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Frank Rowand
On 1/12/21 4:16 AM, Bill Mills wrote: > > > On 1/12/21 3:37 AM, Viresh Kumar wrote: >> On 11-01-21, 20:22, Bill Mills wrote: >>> On 1/11/21 5:06 PM, Frank Rowand wrote: NACK to this specific patch, in its current form. There are restrictions on applying an overlay at runtime that

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Rob Herring
On Mon, Jan 11, 2021 at 4:06 PM Frank Rowand wrote: > > On 1/8/21 2:41 AM, Viresh Kumar wrote: > > Now that fdtoverlay is part of the kernel build, start using it to test > > the unitest overlays we have by applying them statically. > > > > The file overlay_base.dtb have symbols of its own and we

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Bill Mills
On 1/12/21 3:37 AM, Viresh Kumar wrote: On 11-01-21, 20:22, Bill Mills wrote: On 1/11/21 5:06 PM, Frank Rowand wrote: NACK to this specific patch, in its current form. There are restrictions on applying an overlay at runtime that do not apply to applying an overlay to an FDT that will be

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-12 Thread Viresh Kumar
On 11-01-21, 20:22, Bill Mills wrote: > On 1/11/21 5:06 PM, Frank Rowand wrote: > > NACK to this specific patch, in its current form. > > > > There are restrictions on applying an overlay at runtime that do not apply > > to applying an overlay to an FDT that will be loaded by the kernel during >

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-11 Thread Bill Mills
On 1/11/21 5:06 PM, Frank Rowand wrote: On 1/8/21 2:41 AM, Viresh Kumar wrote: Now that fdtoverlay is part of the kernel build, start using it to test the unitest overlays we have by applying them statically. The file overlay_base.dtb have symbols of its own and we need to apply overlay.dtb

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-11 Thread Frank Rowand
On 1/11/21 9:46 AM, Rob Herring wrote: > On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar wrote: >> >> Now that fdtoverlay is part of the kernel build, start using it to test >> the unitest overlays we have by applying them statically. > > Nice idea. > >> The file overlay_base.dtb have symbols of

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-11 Thread Frank Rowand
On 1/8/21 2:41 AM, Viresh Kumar wrote: > Now that fdtoverlay is part of the kernel build, start using it to test > the unitest overlays we have by applying them statically. > > The file overlay_base.dtb have symbols of its own and we need to apply > overlay.dtb to overlay_base.dtb alone first to

Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-11 Thread Rob Herring
On Fri, Jan 8, 2021 at 2:41 AM Viresh Kumar wrote: > > Now that fdtoverlay is part of the kernel build, start using it to test > the unitest overlays we have by applying them statically. Nice idea. > The file overlay_base.dtb have symbols of its own and we need to apply > overlay.dtb to

[PATCH] of: unittest: Statically apply overlays using fdtoverlay

2021-01-08 Thread Viresh Kumar
Now that fdtoverlay is part of the kernel build, start using it to test the unitest overlays we have by applying them statically. The file overlay_base.dtb have symbols of its own and we need to apply overlay.dtb to overlay_base.dtb alone first to make it work, which gives us