On Sunday 16 December 2012 20:04:46 Al Viro wrote:
> On Sun, Dec 16, 2012 at 09:01:10PM +0100, Paul Bolle wrote:
> > > + vma = find_vma(mm, virtp);
> > >
> > > } else if (vma && (vma->vm_flags & VM_IO) && vma->vm_pgoff) {
> >
> > Shouldn't that line become
> >
> > if (vma &&
rently missing an active maintainer, as it is for an old
> hardware (AFAIK, omap is now at version 4, and this is for the first one),
> but I'm c/c a few developers that might help to test and analyze it.
>
> In any case, /me is assuming that your patch is right (as nobody
> complained
Hi Mauro,
On Sunday 06 January 2013 11:02:25 Mauro Carvalho Chehab wrote:
> Em Sat, 15 Dec 2012 20:38:29 + Al Viro escreveu:
> > On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
> > > Walking rbtree while it's modified is a Bad Idea(tm); besides,
> > >
> > > the result of
Hi Mauro,
On Sunday 06 January 2013 11:02:25 Mauro Carvalho Chehab wrote:
Em Sat, 15 Dec 2012 20:38:29 + Al Viro escreveu:
On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be
it.
In any case, /me is assuming that your patch is right (as nobody
complained), and I'm applying it right now on my tree. This will hopefully
allow some people to test.
Please make sure you apply v2 (posted as Re: [PATCH] omap_vout: find_vma()
needs -mmap_sem held).
--
Regards,
Laurent Pinchart
On Sunday 16 December 2012 20:04:46 Al Viro wrote:
On Sun, Dec 16, 2012 at 09:01:10PM +0100, Paul Bolle wrote:
+ vma = find_vma(mm, virtp);
} else if (vma (vma-vm_flags VM_IO) vma-vm_pgoff) {
Shouldn't that line become
if (vma (vma-vm_flags VM_IO) vma-vm_pgoff) {
Hi Viro,
Em Sat, 15 Dec 2012 20:38:29 +
Al Viro escreveu:
> On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
> > Walking rbtree while it's modified is a Bad Idea(tm); besides,
> > the result of find_vma() can be freed just as it's getting returned
> > to caller. Fortunately,
Hi Viro,
Em Sat, 15 Dec 2012 20:38:29 +
Al Viro v...@zeniv.linux.org.uk escreveu:
On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be freed just as it's getting returned
to caller.
On Sun, Dec 16, 2012 at 09:01:10PM +0100, Paul Bolle wrote:
> > + vma = find_vma(mm, virtp);
> > } else if (vma && (vma->vm_flags & VM_IO) && vma->vm_pgoff) {
>
> Shouldn't that line become
> if (vma && (vma->vm_flags & VM_IO) && vma->vm_pgoff) {
>
> so that this actually compiles?
On Sat, 2012-12-15 at 20:12 +, Al Viro wrote:
> Walking rbtree while it's modified is a Bad Idea(tm); besides,
> the result of find_vma() can be freed just as it's getting returned
> to caller. Fortunately, it's easy to fix - just take ->mmap_sem a bit
> earlier (and don't bother with
On Sat, 2012-12-15 at 20:12 +, Al Viro wrote:
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be freed just as it's getting returned
to caller. Fortunately, it's easy to fix - just take -mmap_sem a bit
earlier (and don't bother with
On Sun, Dec 16, 2012 at 09:01:10PM +0100, Paul Bolle wrote:
+ vma = find_vma(mm, virtp);
} else if (vma (vma-vm_flags VM_IO) vma-vm_pgoff) {
Shouldn't that line become
if (vma (vma-vm_flags VM_IO) vma-vm_pgoff) {
so that this actually compiles?
*Do'h*
Yes, it should.
On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
> Walking rbtree while it's modified is a Bad Idea(tm); besides,
> the result of find_vma() can be freed just as it's getting returned
> to caller. Fortunately, it's easy to fix - just take ->mmap_sem a bit
> earlier (and don't bother
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be freed just as it's getting returned
to caller. Fortunately, it's easy to fix - just take ->mmap_sem a bit
earlier (and don't bother with find_vma() at all if virtp >= PAGE_OFFSET -
in that case
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be freed just as it's getting returned
to caller. Fortunately, it's easy to fix - just take -mmap_sem a bit
earlier (and don't bother with find_vma() at all if virtp = PAGE_OFFSET -
in that case we
On Sat, Dec 15, 2012 at 08:12:37PM +, Al Viro wrote:
Walking rbtree while it's modified is a Bad Idea(tm); besides,
the result of find_vma() can be freed just as it's getting returned
to caller. Fortunately, it's easy to fix - just take -mmap_sem a bit
earlier (and don't bother with
16 matches
Mail list logo
