Re: [PATCH] oom: print nodemask in the oom report

2016-10-05 Thread Vlastimil Babka
On 10/04/2016 05:12 PM, Michal Hocko wrote: Ah, I wasn't clear. What I questioned is the fallback to cpusets for NULL nodemask: nodemask_t *nm = (oc->nodemask) ? oc->nodemask : &cpuset_current_mems_allowed; Well no nodemask means there is no mempolicy so either all nodes can be used or they a

Re: [PATCH] oom: print nodemask in the oom report

2016-10-04 Thread Michal Hocko
On Tue 04-10-16 17:02:42, Vlastimil Babka wrote: > On 10/04/2016 04:16 PM, Michal Hocko wrote: > > On Tue 04-10-16 15:24:53, Vlastimil Babka wrote: > > > On 09/30/2016 11:41 PM, Michal Hocko wrote: > > [...] > > > > Fix this by always priting the nodemask. It is either mempolicy mask > > > > (and n

Re: [PATCH] oom: print nodemask in the oom report

2016-10-04 Thread Vlastimil Babka
On 10/04/2016 04:16 PM, Michal Hocko wrote: On Tue 04-10-16 15:24:53, Vlastimil Babka wrote: On 09/30/2016 11:41 PM, Michal Hocko wrote: [...] Fix this by always priting the nodemask. It is either mempolicy mask (and non-null) or the one defined by the cpusets. I wonder if it's helpful to pr

Re: [PATCH] oom: print nodemask in the oom report

2016-10-04 Thread Michal Hocko
On Tue 04-10-16 15:24:53, Vlastimil Babka wrote: > On 09/30/2016 11:41 PM, Michal Hocko wrote: [...] > > Fix this by always priting the nodemask. It is either mempolicy mask > > (and non-null) or the one defined by the cpusets. > > I wonder if it's helpful to print the cpuset one when that's print

Re: [PATCH] oom: print nodemask in the oom report

2016-10-04 Thread Vlastimil Babka
On 09/30/2016 11:41 PM, Michal Hocko wrote: From: Michal Hocko We have received a hard to explain oom report from a customer. The oom triggered regardless there is a lot of free memory: PoolThread invoked oom-killer: gfp_mask=0x280da, order=0, oom_adj=0, oom_score_adj=0 PoolThread cpuset=/ me

[PATCH] oom: print nodemask in the oom report

2016-09-30 Thread Michal Hocko
From: Michal Hocko We have received a hard to explain oom report from a customer. The oom triggered regardless there is a lot of free memory: PoolThread invoked oom-killer: gfp_mask=0x280da, order=0, oom_adj=0, oom_score_adj=0 PoolThread cpuset=/ mems_allowed=0-7 Pid: 30055, comm: PoolThread Ta