Re: [ovs-dev] [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-14 Thread Zoltan Kiss
On 11/03/14 19:41, Zoltan Kiss wrote: On 07/03/14 17:59, Thomas Graf wrote: On 03/07/2014 06:28 PM, Pravin Shelar wrote: Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy is not doing that. Unless I missing something, Current netlink code can not handle skb-frags with zero

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-11 Thread Zoltan Kiss
On 07/03/14 17:59, Thomas Graf wrote: On 03/07/2014 06:28 PM, Pravin Shelar wrote: Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy is not doing that. Unless I missing something, Current netlink code can not handle skb-frags with zero copy. So we have to copy skb anyways a

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 10:05 AM, Thomas Graf wrote: > On 03/07/2014 06:19 PM, Pravin Shelar wrote: >> >> On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf wrote: >>> >>> On 03/07/2014 05:46 AM, Pravin Shelar wrote: But I found bug in datapath user-space queue code. I am not sure how

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 9:59 AM, Thomas Graf wrote: > On 03/07/2014 06:28 PM, Pravin Shelar wrote: >> >> Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy >> is not doing that. >> >> Unless I missing something, Current netlink code can not handle >> skb-frags with zero copy. So

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Thomas Graf
On 03/07/2014 06:19 PM, Pravin Shelar wrote: On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf wrote: On 03/07/2014 05:46 AM, Pravin Shelar wrote: But I found bug in datapath user-space queue code. I am not sure how this can work with skb fragments and MMAP-netlink socket. Here is what happens, OVS

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Thomas Graf
On 03/07/2014 06:28 PM, Pravin Shelar wrote: Problem is mapping SKBTX_DEV_ZEROCOPY pages to userspace. skb_zerocopy is not doing that. Unless I missing something, Current netlink code can not handle skb-frags with zero copy. So we have to copy skb anyways and no need to orphan-frags here. If you

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 4:29 AM, Zoltan Kiss wrote: > On 07/03/14 04:46, Pravin Shelar wrote: >> >> On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss >> wrote: >>> >>> Do you have any feedback on this? I'm also adding KVM list as they might >>> be >>> interested in this. >>> >>> Zoli >>> >>> >>> On 28/0

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 8:23 AM, Thomas Graf wrote: > On 02/28/2014 08:16 PM, Zoltan Kiss wrote: >> >> The kernel datapath now switched to zerocopy Netlink messages, but that >> also >> means that the pages on frags array are sent straight to userspace. If >> those >> pages came outside the kernel,

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Pravin Shelar
On Fri, Mar 7, 2014 at 7:58 AM, Thomas Graf wrote: > On 03/07/2014 05:46 AM, Pravin Shelar wrote: >> >> But I found bug in datapath user-space queue code. I am not sure how >> this can work with skb fragments and MMAP-netlink socket. >> Here is what happens, OVS allocates netlink skb and adds frag

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Thomas Graf
On 02/28/2014 08:16 PM, Zoltan Kiss wrote: The kernel datapath now switched to zerocopy Netlink messages, but that also means that the pages on frags array are sent straight to userspace. If those pages came outside the kernel, we have to swap them out with local copies. Signed-off-by: Zoltan Ki

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Thomas Graf
On 03/07/2014 05:46 AM, Pravin Shelar wrote: But I found bug in datapath user-space queue code. I am not sure how this can work with skb fragments and MMAP-netlink socket. Here is what happens, OVS allocates netlink skb and adds fragments to skb using skb_zero_copy(), then calls genlmsg_unicast()

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-07 Thread Zoltan Kiss
On 07/03/14 04:46, Pravin Shelar wrote: On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss wrote: Do you have any feedback on this? I'm also adding KVM list as they might be interested in this. Zoli On 28/02/14 19:16, Zoltan Kiss wrote: The kernel datapath now switched to zerocopy Netlink message

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-06 Thread Pravin Shelar
On Thu, Mar 6, 2014 at 9:09 AM, Zoltan Kiss wrote: > Do you have any feedback on this? I'm also adding KVM list as they might be > interested in this. > > Zoli > > > On 28/02/14 19:16, Zoltan Kiss wrote: >> >> The kernel datapath now switched to zerocopy Netlink messages, but that >> also >> means

Re: [PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-03-06 Thread Zoltan Kiss
Do you have any feedback on this? I'm also adding KVM list as they might be interested in this. Zoli On 28/02/14 19:16, Zoltan Kiss wrote: The kernel datapath now switched to zerocopy Netlink messages, but that also means that the pages on frags array are sent straight to userspace. If those p

[PATCH] openvswitch: Orphan frags before sending to userspace via Netlink to avoid guest stall

2014-02-28 Thread Zoltan Kiss
The kernel datapath now switched to zerocopy Netlink messages, but that also means that the pages on frags array are sent straight to userspace. If those pages came outside the kernel, we have to swap them out with local copies. Signed-off-by: Zoltan Kiss --- net/openvswitch/datapath.c |6 ++