Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Wed, Sep 18, 2019 at 11:07:31AM +0200, Miklos Szeredi wrote: > On Fri, May 10, 2019 at 04:09:41PM -0400, J. Bruce Fields wrote: > > On Tue, May 07, 2019 at 10:24:58AM +1000, NeilBrown wrote: > > > Interesting perspective though doesn't NFSv4 explicitly allow > > > client-side ACL

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 10, 2019 at 04:09:41PM -0400, J. Bruce Fields wrote: > On Tue, May 07, 2019 at 10:24:58AM +1000, NeilBrown wrote: > > Interesting perspective though doesn't NFSv4 explicitly allow > > client-side ACL enforcement in the case of delegations? > > Not really. What you're probably

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, May 07, 2019 at 10:24:58AM +1000, NeilBrown wrote: > Interesting perspective though doesn't NFSv4 explicitly allow > client-side ACL enforcement in the case of delegations? Not really. What you're probably thinking of is the single ACE that the server can return on granting a

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, May 07, 2019 at 04:07:21AM -0400, Miklos Szeredi wrote: > On Fri, May 3, 2019 at 11:35 AM J. Bruce Fields wrote: > > > > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > > > > Silently not copying the ACLs is probably not a good idea as it might > > > result in

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 3, 2019 at 11:35 AM J. Bruce Fields wrote: > > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > > Silently not copying the ACLs is probably not a good idea as it might > > result in inappropriate permissions being given away. So if the > > sysadmin wants this (and

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 03 2019, J. Bruce Fields wrote: > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: >> On Tue, Dec 06 2016, J. Bruce Fields wrote: >> >> > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: >> >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: >> >>

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 03, 2019 at 01:41:25PM -0400, Amir Goldstein wrote: > On Fri, May 3, 2019 at 1:31 PM J. Bruce Fields wrote: > > > > On Fri, May 03, 2019 at 01:26:01PM -0400, Amir Goldstein wrote: > > > On Fri, May 3, 2019 at 12:03 PM J. Bruce Fields > > > wrote: > > > > > > > > On Thu, May 02, 2019

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 3, 2019 at 1:31 PM J. Bruce Fields wrote: > > On Fri, May 03, 2019 at 01:26:01PM -0400, Amir Goldstein wrote: > > On Fri, May 3, 2019 at 12:03 PM J. Bruce Fields > > wrote: > > > > > > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > > > > On Tue, Dec 06 2016, J. Bruce

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 5/3/19 10:27 AM, J. Bruce Fields wrote: > Christoph also had some objections to the implementation which I think > were addressed, but I could be wrong. I'm certainly no expert, but yes, the objections to the RichACL patches were addressed and not really counter challenged. It seems like a

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 03, 2019 at 01:26:01PM -0400, Amir Goldstein wrote: > On Fri, May 3, 2019 at 12:03 PM J. Bruce Fields wrote: > > > > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > > > On Tue, Dec 06 2016, J. Bruce Fields wrote: > > > > > > > On Tue, Dec 06, 2016 at 02:18:31PM +0100,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Fri, May 3, 2019 at 12:03 PM J. Bruce Fields wrote: > > On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > > On Tue, Dec 06 2016, J. Bruce Fields wrote: > > > > > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > > >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > On Tue, Dec 06 2016, J. Bruce Fields wrote: > > > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > >> > On Tue, Dec 6, 2016 at 12:24 AM, Andreas

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 02, 2019 at 05:51:12PM +, Goetz, Patrick G wrote: > > > On 5/2/19 12:44 PM, Andreas Gruenbacher wrote: > > On Thu, 2 May 2019 at 19:27, Goetz, Patrick G > > wrote: > >> On 5/1/19 10:57 PM, NeilBrown wrote: > >>> Support some day support for nfs4 acls were added to ext4 (not a

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

Am Fr., 3. Mai 2019 um 01:24 Uhr schrieb NeilBrown : > On Thu, May 02 2019, Andreas Gruenbacher wrote: > > On Thu, 2 May 2019 at 05:57, NeilBrown wrote: > >> On Wed, May 01 2019, Amir Goldstein wrote: > >> > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: > >> >> On Tue, Dec 06 2016, J. Bruce

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 02 2019, Andreas Gruenbacher wrote: > On Thu, 2 May 2019 at 05:57, NeilBrown wrote: >> On Wed, May 01 2019, Amir Goldstein wrote: >> > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: >> >> On Tue, Dec 06 2016, J. Bruce Fields wrote: >> >> > On Tue, Dec 06, 2016 at 02:18:31PM +0100,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 02 2019, Miklos Szeredi wrote: > On Thu, May 2, 2019 at 10:05 AM Andreas Gruenbacher > wrote: >> >> On Thu, 2 May 2019 at 05:57, NeilBrown wrote: >> > On Wed, May 01 2019, Amir Goldstein wrote: >> > > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: >> > >> On Tue, Dec 06 2016, J.

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 5/2/19 12:44 PM, Andreas Gruenbacher wrote: > On Thu, 2 May 2019 at 19:27, Goetz, Patrick G wrote: >> On 5/1/19 10:57 PM, NeilBrown wrote: >>> Support some day support for nfs4 acls were added to ext4 (not a totally >>> ridiculous suggestion). We would then want NFS to allow it's ACLs to be

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, 2 May 2019 at 19:16, J. Bruce Fields wrote: > On Thu, May 02, 2019 at 05:08:14PM +0200, Andreas Grünbacher wrote: > > You'll still see permissions that differ from what the filesystem > > enforces, and copy-up would change that behavior. > > That's always true, and this issue isn't really

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, 2 May 2019 at 19:27, Goetz, Patrick G wrote: > On 5/1/19 10:57 PM, NeilBrown wrote: > > Support some day support for nfs4 acls were added to ext4 (not a totally > > ridiculous suggestion). We would then want NFS to allow it's ACLs to be > > copied up. > > Is there some reason why there

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 5/1/19 10:57 PM, NeilBrown wrote: > Support some day support for nfs4 acls were added to ext4 (not a totally > ridiculous suggestion). We would then want NFS to allow it's ACLs to be > copied up. Is there some reason why there hasn't been a greater effort to add NFSv4 ACL support to the

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 02, 2019 at 05:08:14PM +0200, Andreas Grünbacher wrote: > You'll still see permissions that differ from what the filesystem > enforces, and copy-up would change that behavior. That's always true, and this issue isn't really specific to NFSv4 ACLs (or ACLs at all), it already exists

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

Am Do., 2. Mai 2019 um 16:28 Uhr schrieb Miklos Szeredi : > On Thu, May 2, 2019 at 10:05 AM Andreas Gruenbacher > wrote: > > On Thu, 2 May 2019 at 05:57, NeilBrown wrote: > > > On Wed, May 01 2019, Amir Goldstein wrote: > > > > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: > > > >> On Tue,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, May 2, 2019 at 10:05 AM Andreas Gruenbacher wrote: > > On Thu, 2 May 2019 at 05:57, NeilBrown wrote: > > On Wed, May 01 2019, Amir Goldstein wrote: > > > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: > > >> On Tue, Dec 06 2016, J. Bruce Fields wrote: > > >> > On Tue, Dec 06, 2016 at

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Thu, 2 May 2019 at 05:57, NeilBrown wrote: > On Wed, May 01 2019, Amir Goldstein wrote: > > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: > >> On Tue, Dec 06 2016, J. Bruce Fields wrote: > >> > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > >> >> On Tue, Dec 6, 2016

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Wed, May 01 2019, Amir Goldstein wrote: > On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: >> >> On Tue, Dec 06 2016, J. Bruce Fields wrote: >> >> > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: >> >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: >> >> > On

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Wed, May 1, 2019 at 10:03 PM NeilBrown wrote: > > On Tue, Dec 06 2016, J. Bruce Fields wrote: > > > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > >> > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher > >>

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 06 2016, J. Bruce Fields wrote: > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: >> > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher >> > wrote: >> >> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher > > wrote: > >> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher >

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher > > wrote: > >> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher > >> : > > > >>> It's not hard to come up with a

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher > wrote: >> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : > >>> It's not hard to come up with a heuristic

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher > wrote: >> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : > >>> It's not hard to come up with a heuristic that determines if a >>> system.nfs4_acl value is equivalent to a file mode, and

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher wrote: > 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : >> It's not hard to come up with a heuristic that determines if a >> system.nfs4_acl value is equivalent to a file mode, and

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher wrote: > 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : >> It's not hard to come up with a heuristic that determines if a >> system.nfs4_acl value is equivalent to a file mode, and to ignore the >> attribute in that case. (The file mode is

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : > 2016-12-05 23:58 GMT+01:00 Patrick Plagwitz : >> On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: >>> 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : On Mon, Dec 05,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-06 0:19 GMT+01:00 Andreas Grünbacher : > 2016-12-05 23:58 GMT+01:00 Patrick Plagwitz : >> On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: >>> 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: > On Mon, Dec 5, 2016 at

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 23:58 GMT+01:00 Patrick Plagwitz : > On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: >> 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : >>> On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: On Mon, Dec 5, 2016 at 4:19 PM,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 23:58 GMT+01:00 Patrick Plagwitz : > On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: >> 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : >>> On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> Can NFS

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: > 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : >> On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >>> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields >>> wrote: > Can NFS people

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 08:37 PM, Andreas Grünbacher wrote: > 2016-12-05 17:25 GMT+01:00 J. Bruce Fields : >> On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >>> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields >>> wrote: > Can NFS people comment on this? Where does the nfs4_acl come

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 17:25 GMT+01:00 J. Bruce Fields : > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> >> Can NFS people comment on this? Where does the nfs4_acl come from? >> > >> >

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 17:25 GMT+01:00 J. Bruce Fields : > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> >> Can NFS people comment on this? Where does the nfs4_acl come from? >> > >> > This is the interface the NFS client

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 05:25 PM, J. Bruce Fields wrote: > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: Can NFS people comment on this? Where does the nfs4_acl come from? >>> >>> This is the interface

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On 12/05/2016 05:25 PM, J. Bruce Fields wrote: > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: Can NFS people comment on this? Where does the nfs4_acl come from? >>> >>> This is the interface the NFS client provides

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: > On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: > >> Can NFS people comment on this? Where does the nfs4_acl come from? > > > > This is the interface the NFS client provides for applications to modify

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: > On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: > >> Can NFS people comment on this? Where does the nfs4_acl come from? > > > > This is the interface the NFS client provides for applications to modify > > NFSv4 ACLs on

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> Can NFS people comment on this? Where does the nfs4_acl come from? > > This is the interface the NFS client provides for applications to modify > NFSv4 ACLs on servers that support them. Fine, but why are we seeing

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> Can NFS people comment on this? Where does the nfs4_acl come from? > > This is the interface the NFS client provides for applications to modify > NFSv4 ACLs on servers that support them. Fine, but why are we seeing this xattr on exports

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 05, 2016 at 10:28:18AM +0100, Miklos Szeredi wrote: > [Added a few more CCs] > > On Mon, Dec 5, 2016 at 1:51 AM, Patrick Plagwitz > wrote: > > Mounting an overlayfs with an NFSv4 lowerdir and an ext4 upperdir causes > > copy_up operations, specifically the

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

On Mon, Dec 05, 2016 at 10:28:18AM +0100, Miklos Szeredi wrote: > [Added a few more CCs] > > On Mon, Dec 5, 2016 at 1:51 AM, Patrick Plagwitz > wrote: > > Mounting an overlayfs with an NFSv4 lowerdir and an ext4 upperdir causes > > copy_up operations, specifically the function

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

[Added a few more CCs] On Mon, Dec 5, 2016 at 1:51 AM, Patrick Plagwitz wrote: > Mounting an overlayfs with an NFSv4 lowerdir and an ext4 upperdir causes > copy_up operations, specifically the function copy_up.c:ovl_copy_xattr, to > fail with EOPNOTSUPP. > For example,

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

[Added a few more CCs] On Mon, Dec 5, 2016 at 1:51 AM, Patrick Plagwitz wrote: > Mounting an overlayfs with an NFSv4 lowerdir and an ext4 upperdir causes > copy_up operations, specifically the function copy_up.c:ovl_copy_xattr, to > fail with EOPNOTSUPP. > For example, having the following