Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:38, angkery wrote: On Fri, 9 Apr 2021 20:02:56 +0300 Sergei Shtylyov wrote: On 4/9/21 7:49 PM, Sergei Shtylyov wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread angkery
On Fri, 9 Apr 2021 20:02:56 +0300 Sergei Shtylyov wrote: > On 4/9/21 7:49 PM, Sergei Shtylyov wrote: > > >> From: Junlin Yang > >> > >> The return from the call to platform_get_irq() is int, it can be > >> a negative error code, however this is being assigned to an > >> unsigned int variable

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Sergei Shtylyov
On 4/9/21 7:49 PM, Sergei Shtylyov wrote: >> From: Junlin Yang >> >> The return from the call to platform_get_irq() is int, it can be >> a negative error code, however this is being assigned to an unsigned >> int variable 'irq', so making 'irq' an int, and change the position to >> keep the code

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Sergei Shtylyov
On 4/9/21 4:54 PM, angkery wrote: > From: Junlin Yang > > The return from the call to platform_get_irq() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'irq', so making 'irq' an int, and change the position to > keep the code format. > >

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Jens Axboe
On 4/9/21 7:54 AM, angkery wrote: > From: Junlin Yang > > The return from the call to platform_get_irq() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'irq', so making 'irq' an int, and change the position to > keep the code format. > >

[PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread angkery
From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. ./drivers/ata/pata_ixp4xx_cf.c:168:5-8: WARNING: