> > NAK this too
>
> OK, I'm able to understand the meaning of "NAK" [1] but "this too"?
That was me being confusing with something else I NAKked that wasn't
from you. It may have made sense to Jeff but not you - sorry
> PIO fix was directly ported from my it821x.c patch. I now see that thanks
Hi Alan!
On Sunday 10 June 2007, Alan Cox wrote:
> > @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode(
> > static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66,
> > ATA_ANY };
> >
> > struct it821x_dev *itdev = ap->private_data;
> > + struct ata_device *pair =
> @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode(
> static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66,
> ATA_ANY };
>
> struct it821x_dev *itdev = ap->private_data;
> + struct ata_device *pair = ata_dev_pair(adev);
> int unit = adev->devno;
> -
> Hmmm... indeed. Alan, is there any reason we do that in ->set_piomode
> not ->mode_filter? We end up with mismatching configuration between the
> controller and the higher speed drive.
We always talk more slowly than the drive which is just fine. Just about
every device on every controller doe
Bartlomiej Zolnierkiewicz wrote:
>>> @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode(
>>> static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66,
>>> ATA_ANY };
>>>
>>> struct it821x_dev *itdev = ap->private_data;
>>> + struct ata_device *pair = ata_dev_pair(adev
Hello,
On Saturday 09 June 2007, Tejun Heo wrote:
> Hello,
>
> Bartlomiej Zolnierkiewicz wrote:
> > * (partially) fix DMA in RAID mode
> >
> > Code intended to check DMA status was checking DMA command register.
> > Moreover firmware seems to "forget" to set DMA capable bit for the
> > sl
Hello,
Bartlomiej Zolnierkiewicz wrote:
> * (partially) fix DMA in RAID mode
>
> Code intended to check DMA status was checking DMA command register.
> Moreover firmware seems to "forget" to set DMA capable bit for the
> slave device (at least in RAID mode but without ITE RAID volumes) so
>
* fix PIO setup for devices with different PIO speeds in passthru mode
IT821x allows one PIO setting per port se we have to limit maximum
PIO mode to the one of the slowest device on the port.
* (partially) fix DMA in RAID mode
Code intended to check DMA status was checking DMA command re
8 matches
Mail list logo
