Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 03:02:13 PM Bartlomiej Zolnierkiewicz wrote: > On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote: > > Fix these checkpatch.pl error: > > ERROR: space prohibited before open square bracket '['. > > > > ERROR: space prohibited after that '~' (ctx:WxW) > > +

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-12-05 Thread Bartlomiej Zolnierkiewicz
On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote: > Fix these checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); > > ERROR: spaces required around t

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread arvindY
Hi Joe, On Saturday 25 November 2017 04:32 PM, Joe Perches wrote: On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_fa

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread Joe Perches
On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] > diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] > @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct > ata_device **r_failed > */ > static struct pdc2027x_pio_timing { > u8 valu

[PATCH] pata_pdc2027x: Fix coding sytle error

2017-11-25 Thread Arvind Yadav
Fix these checkpatch.pl error: ERROR: space prohibited before open square bracket '['. ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces required around that '?' (ctx:VxW) + long pout_required = board_idx? PDC_133_MHZ:PDC_1