Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-25 Thread arvindY
Hi Sergei, On Saturday 25 November 2017 03:30 PM, Sergei Shtylyov wrote: On 11/25/2017 7:15 AM, Arvind Yadav wrote: Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that '~'

Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-25 Thread Sergei Shtylyov
On 11/25/2017 7:15 AM, Arvind Yadav wrote: Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: s

Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-24 Thread Joe Perches
On Sat, 2017-11-25 at 09:45 +0530, Arvind Yadav wrote: > Here, The function pdc_hardware_init always return zero. So it is not > necessary to check its return value. > > Fix these checkpatch.pl error: > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SH

[PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-24 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces required around that '?' (ctx:VxW) +