Re: [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE

2013-12-13 Thread Bjorn Helgaas
On Mon, Dec 02, 2013 at 09:43:37AM -0800, Joe Perches wrote: > Prefer use of the direct definition of struct pci_device_id > instead of indirection via macro DEFINE_PCI_DEVICE_TABLE. > > Update the PCI documentation to deprecate DEFINE_PCI_DEVICE_TABLE. > Update checkpatch adding --fix option. >

Re: [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE

2013-12-02 Thread Jingoo Han
On Tuesday, December 03, 2013 2:44 AM, Joe Perches > > Prefer use of the direct definition of struct pci_device_id > instead of indirection via macro DEFINE_PCI_DEVICE_TABLE. > > Update the PCI documentation to deprecate DEFINE_PCI_DEVICE_TABLE. > Update checkpatch adding --fix option. > > Signe

Re: [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE

2013-12-02 Thread Joe Perches
On Mon, 2013-12-02 at 10:01 -0800, Guenter Roeck wrote: > On Mon, Dec 02, 2013 at 09:43:37AM -0800, Joe Perches wrote: > > Prefer use of the direct definition of struct pci_device_id [] > > +all-zero entry. Definitions with static const are generally preferred. see here: > Add 'const' ? Also se

Re: [PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE

2013-12-02 Thread Guenter Roeck
On Mon, Dec 02, 2013 at 09:43:37AM -0800, Joe Perches wrote: > Prefer use of the direct definition of struct pci_device_id Add 'const' ? > instead of indirection via macro DEFINE_PCI_DEVICE_TABLE. > > Update the PCI documentation to deprecate DEFINE_PCI_DEVICE_TABLE. > Update checkpatch adding -

[PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE

2013-12-02 Thread Joe Perches
Prefer use of the direct definition of struct pci_device_id instead of indirection via macro DEFINE_PCI_DEVICE_TABLE. Update the PCI documentation to deprecate DEFINE_PCI_DEVICE_TABLE. Update checkpatch adding --fix option. Signed-off-by: Joe Perches --- Documentation/PCI/pci.txt | 6 -- i