Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-25 Thread Bjorn Helgaas
On Fri, Sep 22, 2017 at 08:12:46PM +0200, Geert Uytterhoeven wrote: > Hi Björn, > > On Fri, Sep 22, 2017 at 5:56 PM, Bjorn Helgaas wrote: > > On Mon, Sep 11, 2017 at 02:29:15PM +0200, Geert Uytterhoeven wrote: > >> If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline > >> get_pci_function_

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-22 Thread Geert Uytterhoeven
Hi Björn, On Fri, Sep 22, 2017 at 5:56 PM, Bjorn Helgaas wrote: > On Mon, Sep 11, 2017 at 02:29:15PM +0200, Geert Uytterhoeven wrote: >> If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline >> get_pci_function_alias_group(), the build fails with: >> >> drivers/iommu/iommu.o: In functio

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-22 Thread Joerg Roedel
Hey Bjorn, On Fri, Sep 22, 2017 at 10:56:05AM -0500, Bjorn Helgaas wrote: > Joerg, if you pick this up, would you mind capitalizing the subject > line to match the PCI convention, e.g., > > PCI: Add dummy pci_acs_enabled() for CONFIG_PCI=n build > > If it's too late for you to pick this up thi

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-22 Thread Bjorn Helgaas
On Mon, Sep 11, 2017 at 02:29:15PM +0200, Geert Uytterhoeven wrote: > If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline > get_pci_function_alias_group(), the build fails with: > > drivers/iommu/iommu.o: In function `get_pci_function_alias_group': > iommu.c:(.text+0xfdc): undefine

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-20 Thread Alex Williamson
On Mon, 11 Sep 2017 14:29:15 +0200 Geert Uytterhoeven wrote: > If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline > get_pci_function_alias_group(), the build fails with: > > drivers/iommu/iommu.o: In function `get_pci_function_alias_group': > iommu.c:(.text+0xfdc): undefined ref

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-20 Thread Joerg Roedel
Hey Bjorn, On Mon, Sep 11, 2017 at 02:29:15PM +0200, Geert Uytterhoeven wrote: > If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline > get_pci_function_alias_group(), the build fails with: > > drivers/iommu/iommu.o: In function `get_pci_function_alias_group': > iommu.c:(.text+0xfd

[PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-11 Thread Geert Uytterhoeven
If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline get_pci_function_alias_group(), the build fails with: drivers/iommu/iommu.o: In function `get_pci_function_alias_group': iommu.c:(.text+0xfdc): undefined reference to `pci_acs_enabled' Due to the various dummies for PCI calls in