Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-15 Thread Jan Engelhardt
On Sep 13 2007 02:42, Jeff Garzik wrote: > Alexey Dobriyan wrote: >> -static struct pci_device_id rtl8139_pci_tbl[] = { >> +PCI_MODULE_DEVICE_TABLE_BEGIN(rtl8139_pci_tbl) >> {0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, >> {0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, >

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Sam Ravnborg
On Thu, Sep 13, 2007 at 10:34:02AM +0400, Alexey Dobriyan wrote: > [non-terminated PCI ids arrays] > > Here is compile-time hack (yep, warped and whitespace damaged :)) > It's better than modpost-time hack. because it triggers earlier. > It's worse than modpost-time hack, because of tree-wide chan

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Jeff Garzik
Alexey Dobriyan wrote: -static struct pci_device_id rtl8139_pci_tbl[] = { +PCI_MODULE_DEVICE_TABLE_BEGIN(rtl8139_pci_tbl) {0x10ec, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, {0x10ec, 0x8138, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, {0x1113, 0x1211, PCI_ANY_ID, PCI_AN

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Alexey Dobriyan
[non-terminated PCI ids arrays] Here is compile-time hack (yep, warped and whitespace damaged :)) It's better than modpost-time hack. because it triggers earlier. It's worse than modpost-time hack, because of tree-wide changes. diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c index f4e4

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 14:53:56 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: > > On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Kees Cook wrote: > > > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > > > co

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 03:48:49PM +0400, Alexey Dobriyan wrote: > On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Kees Cook wrote: > > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > > correctly terminate their pci_device_id lists. This results in garbage > > > being

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Alexey Dobriyan
On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kees Cook wrote: > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > correctly terminate their pci_device_id lists. This results in garbage > > being spewed into modules.pcimap when the module happens to not have > > 28 NULL

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Jeff Garzik
Kees Cook wrote: This patch against 2.6.23-rc6 fixes a couple drivers that do not correctly terminate their pci_device_id lists. This results in garbage being spewed into modules.pcimap when the module happens to not have 28 NULL bytes following the table, and/or the last PCI ID is actually trun

[PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Kees Cook
This patch against 2.6.23-rc6 fixes a couple drivers that do not correctly terminate their pci_device_id lists. This results in garbage being spewed into modules.pcimap when the module happens to not have 28 NULL bytes following the table, and/or the last PCI ID is actually truncated from the tabl