Re: [PATCH] pci: remove redundant function calls in pci_reassigndev_resource_alignment()

2013-01-24 Thread Bjorn Helgaas
On Fri, Dec 28, 2012 at 1:55 AM, Lin Feng wrote: > > > On 12/28/2012 03:45 PM, Yinghai Lu wrote: >> On Thu, Dec 27, 2012 at 11:31 PM, Lin Feng wrote: >>> pci_reassigndev_resource_alignment() potentially calls >>> pci_specified_resource_alignment() twice, which is redundant. >>> >>> pci_is_reassig

Re: [PATCH] pci: remove redundant function calls in pci_reassigndev_resource_alignment()

2012-12-28 Thread Lin Feng
On 12/28/2012 03:45 PM, Yinghai Lu wrote: > On Thu, Dec 27, 2012 at 11:31 PM, Lin Feng wrote: >> pci_reassigndev_resource_alignment() potentially calls >> pci_specified_resource_alignment() twice, which is redundant. >> >> pci_is_reassigndev() is only called in pci_reassigndev_resource_alignment

Re: [PATCH] pci: remove redundant function calls in pci_reassigndev_resource_alignment()

2012-12-27 Thread Yinghai Lu
On Thu, Dec 27, 2012 at 11:31 PM, Lin Feng wrote: > pci_reassigndev_resource_alignment() potentially calls > pci_specified_resource_alignment() twice, which is redundant. > > pci_is_reassigndev() is only called in pci_reassigndev_resource_alignment(), > and from sematic/functionality aspects pci_s

[PATCH] pci: remove redundant function calls in pci_reassigndev_resource_alignment()

2012-12-27 Thread Lin Feng
pci_reassigndev_resource_alignment() potentially calls pci_specified_resource_alignment() twice, which is redundant. pci_is_reassigndev() is only called in pci_reassigndev_resource_alignment(), and from sematic/functionality aspects pci_specified_resource_alignment() is sufficient to substitute, s