Re: [PATCH] pci_find_device --> pci_get_device [only marks deprecation]

2005-07-27 Thread Jiri Slaby
On 7/28/05, Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 7/19/05, Rolf Eike Beer <[EMAIL PROTECTED]> wrote: > > Jiri Slaby wrote: > > >* Marks the function as deprecated in pci.h > [it is meant pci_find_device] > > > > This is a very good idea in my eyes. > > 2.6.13-rc3-mm2 > > Signed-off-by: Jiri

Re: [PATCH] pci_find_device --> pci_get_device [only marks deprecation]

2005-07-27 Thread Jiri Slaby
On 7/19/05, Rolf Eike Beer <[EMAIL PROTECTED]> wrote: Jiri Slaby wrote: >* Marks the function as deprecated in pci.h [it is meant pci_find_device] This is a very good idea in my eyes. 2.6.13-rc3-mm2 Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> diff --git a/include/linux/pci.h b/include/li

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Jiri Slaby
Rolf Eike Beer napsal(a): Jiri Slaby wrote: Is there any difference? I don't see any, but... The reading of diff file in this case is not the best, maybe... Yes, that was the problem. I would prefer if you could just remove the code instead of commenting it out. This would have made

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Rolf Eike Beer
Jiri Slaby wrote: >Rolf Eike Beer napsal(a): >>Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: >>>Rolf Eike Beer napsal(a): Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added parts do not match in behaviour. >>> >>>I can't still see the difference. >> >>diff --gi

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Jiri Slaby
Rolf Eike Beer napsal(a): Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: Rolf Eike Beer napsal(a): Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added parts do not match in behaviour. I can't still see the difference. diff --git a/arch/sparc64

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: >Rolf Eike Beer napsal(a): >>Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added >>parts do not match in behaviour. > >I can't still see the difference. diff --git a/arch/sparc64/kernel/ebus.c b/arch/sparc64/kernel/ebus.c -

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Jiri Slaby
Rolf Eike Beer napsal(a): Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added parts do not match in behaviour. I can't still see the difference. if (pdev && (pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS)) *is_rio_p = 1; else *is_rio_p = 0; AND *is_rio_p = !!(pdev &

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Rolf Eike Beer
Am Dienstag, 19. Juli 2005 17:44 schrieb Jiri Slaby: >Rolf Eike Beer napsal(a): >>Jiri Slaby wrote: >>>Kernel version: 2.6.13-rc3-git4 >>> >>>* This patch removes from kernel tree pci_find_device and changes >>>it with pci_get_device. Next, it adds pci_dev_put, to decrease reference >>>count of the

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Jiri Slaby
Rolf Eike Beer napsal(a): Jiri Slaby wrote: Kernel version: 2.6.13-rc3-git4 * This patch removes from kernel tree pci_find_device and changes it with pci_get_device. Next, it adds pci_dev_put, to decrease reference count of the variable. * Next, there are some (about 10 or so) gcc warning p

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Rolf Eike Beer
Jiri Slaby wrote: >The patch is for mixed files from all over the tree. > >Kernel version: 2.6.13-rc3-git4 > >* This patch removes from kernel tree pci_find_device and changes >it with pci_get_device. Next, it adds pci_dev_put, to decrease reference >count of the variable. >* Next, there are some (

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Rogier Wolff
On Tue, Jul 19, 2005 at 12:53:38PM +0200, Jiri Slaby wrote: > Rogier Wolff napsal(a): > I don't know, if you think it global, or if am I here with other > fellows (no, I'm not). I don't know what kind of comment you have > on your mind. Could you, please, specify it more. I only changed > names

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Jiri Slaby
Rogier Wolff napsal(a): On Tue, Jul 19, 2005 at 02:25:23AM +0200, Jiri Slaby wrote: The patch is for mixed files from all over the tree. Kernel version: 2.6.13-rc3-git4 * This patch removes from kernel tree pci_find_device and changes it with pci_get_device. Next, it adds pci_dev_put, to d

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-18 Thread Rogier Wolff
On Tue, Jul 19, 2005 at 02:25:23AM +0200, Jiri Slaby wrote: > The patch is for mixed files from all over the tree. > > Kernel version: 2.6.13-rc3-git4 > > * This patch removes from kernel tree pci_find_device and changes > it with pci_get_device. Next, it adds pci_dev_put, to decrease reference >

[PATCH] pci_find_device --> pci_get_device

2005-07-18 Thread Jiri Slaby
The patch is for mixed files from all over the tree. Kernel version: 2.6.13-rc3-git4 * This patch removes from kernel tree pci_find_device and changes it with pci_get_device. Next, it adds pci_dev_put, to decrease reference count of the variable. * Next, there are some (about 10 or so) gcc warni