[PATCH] pci_get_device call from interrupt in reboot fixups (description fixed)

2007-08-07 Thread Denis V. Lunev
The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device pci_get_subsys down_read The patch skips reboot fixup if called from sysrq-B code. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- reboot_fix

[PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Denis V. Lunev
The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device pci_get_subsys down_read The patch skips reboot fixup if called from sysrq-B code. --- --- ./arch/i386/kernel/reboot_fixups.c.fixup2 2007-08-07 12

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Greg KH
On Tue, Aug 07, 2007 at 12:44:55AM -0700, Andrew Morton wrote: > On Tue, 7 Aug 2007 00:24:37 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Andrew, I really don't want to change the PCI core to handle this, as we > > > finally fixed a lot of issues with drivers trying to walk these lists >

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Denis V. Lunev
Andrew Morton wrote: > On Mon, 6 Aug 2007 19:49:10 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > >> On Mon, Aug 06, 2007 at 11:16:20AM +0400, Denis V. Lunev wrote: >>> Greg KH wrote: On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: > The following calltrace is possible now: >>

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Denis V. Lunev
Greg KH wrote: > On Tue, Aug 07, 2007 at 12:44:55AM -0700, Andrew Morton wrote: >> On Tue, 7 Aug 2007 00:24:37 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: >> Andrew, I really don't want to change the PCI core to handle this, as we finally fixed a lot of issues with drivers trying to wa

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Andrew Morton
On Tue, 7 Aug 2007 00:24:37 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Andrew, I really don't want to change the PCI core to handle this, as we > > finally fixed a lot of issues with drivers trying to walk these lists > > from interrupt context. So if you want to just hide the warning mes

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-07 Thread Andrew Morton
On Mon, 6 Aug 2007 19:49:10 -0700 Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Aug 06, 2007 at 11:16:20AM +0400, Denis V. Lunev wrote: > > Greg KH wrote: > > > On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: > > >> The following calltrace is possible now: > > >> handle_sysrq > > >

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Greg KH
On Mon, Aug 06, 2007 at 11:16:20AM +0400, Denis V. Lunev wrote: > Greg KH wrote: > > On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: > >> The following calltrace is possible now: > >> handle_sysrq > >>machine_emergency_restart > >> mach_reboot_fixups > >>pci_get_de

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Andrew Morton
On Fri, 3 Aug 2007 14:39:24 +0400 "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > The following calltrace is possible now: > handle_sysrq >machine_emergency_restart > mach_reboot_fixups >pci_get_device > pci_get_subsys > down_read > The patch obtains PCI device du

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-06 Thread Denis V. Lunev
Greg KH wrote: > On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: >> The following calltrace is possible now: >> handle_sysrq >>machine_emergency_restart >> mach_reboot_fixups >>pci_get_device >> pci_get_subsys >> down_read >> The patch obtains PCI

Re: [PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-03 Thread Greg KH
On Fri, Aug 03, 2007 at 02:39:24PM +0400, Denis V. Lunev wrote: > The following calltrace is possible now: > handle_sysrq >machine_emergency_restart > mach_reboot_fixups >pci_get_device > pci_get_subsys > down_read > The patch obtains PCI device during initializa

[PATCH] pci_get_device call from interrupt in reboot fixups

2007-08-03 Thread Denis V. Lunev
The following calltrace is possible now: handle_sysrq machine_emergency_restart mach_reboot_fixups pci_get_device pci_get_subsys down_read The patch obtains PCI device during initialization to avoid bothering PCI search engine in interrupt. Devices used in this c