Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-06-06 Thread Martin Mokrejs
Takashi Iwai wrote: > At Wed, 20 Mar 2013 19:41:38 +0100, > Martin Mokrejs wrote: >> >> Hi Takashi, >> would you please describe your test system in more detail? How >> about 'lspci -tv'? And 'lsusb -v' of the broken device? > > I left the machine in my office, so I'll give details tomorrow. > I

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-04-11 Thread Takashi Iwai
At Wed, 10 Apr 2013 11:19:48 -0600, Bjorn Helgaas wrote: > > On Wed, Apr 10, 2013 at 10:34 AM, Takashi Iwai wrote: > > Hi Bjorn, > > > > sorry for the late follow up as I was on vacation and has been busy > > for other tasks. Since this topic went to nirvana, I try to whip > > again... > > > > A

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-04-10 Thread Bjorn Helgaas
On Wed, Apr 10, 2013 at 10:34 AM, Takashi Iwai wrote: > Hi Bjorn, > > sorry for the late follow up as I was on vacation and has been busy > for other tasks. Since this topic went to nirvana, I try to whip > again... > > At Mon, 25 Mar 2013 10:58:40 -0600, > Bjorn Helgaas wrote: >> >> On Wed, Mar

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-04-10 Thread Takashi Iwai
Hi Bjorn, sorry for the late follow up as I was on vacation and has been busy for other tasks. Since this topic went to nirvana, I try to whip again... At Mon, 25 Mar 2013 10:58:40 -0600, Bjorn Helgaas wrote: > > On Wed, Mar 20, 2013 at 8:02 AM, Takashi Iwai wrote: > > We encountered a problem

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-27 Thread Michal Marek
On 27.3.2013 17:11, Oliver Neukum wrote: > On Friday 22 March 2013 10:20:43 Alex Williamson wrote: > >>> (*) It would probably make more sense to have a list of dmi strings, >>> because it's the PCIe controller that does not set the capability bit >>> when it should. The device (Realtek card reade

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-27 Thread Oliver Neukum
On Friday 22 March 2013 10:20:43 Alex Williamson wrote: > > (*) It would probably make more sense to have a list of dmi strings, > > because it's the PCIe controller that does not set the capability bit > > when it should. The device (Realtek card reader in this case) seems to > > behave correctly

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-25 Thread Bjorn Helgaas
On Wed, Mar 20, 2013 at 8:02 AM, Takashi Iwai wrote: > We encountered a problem that on some HP machines the Realtek PCI-e > card reader device appears only when you inserted a card before the > cold boot. While debugging, it turned out that the device is actually > handled via PCI-e hotplug in s

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-22 Thread Michal Marek
On 22.3.2013 17:16, Matthew Garrett wrote: > On Fri, Mar 22, 2013 at 05:15:04PM +0100, Michal Marek wrote: > >> Alex, Matthew, would it work for you to have this debug / band-aid >> option _and_ have a list of either machines' dmi strings that have this >> problem, or devices' PCI IDs (*), and ena

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-22 Thread Alex Williamson
On Fri, 2013-03-22 at 17:15 +0100, Michal Marek wrote: > On 20.3.2013 20:08, Takashi Iwai wrote: > > At Wed, 20 Mar 2013 12:09:13 -0600, > > Alex Williamson wrote: > >> > >> On Wed, 2013-03-20 at 15:02 +0100, Takashi Iwai wrote: > >>> We encountered a problem that on some HP machines the Realtek PC

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-22 Thread Matthew Garrett
On Fri, Mar 22, 2013 at 05:15:04PM +0100, Michal Marek wrote: > Alex, Matthew, would it work for you to have this debug / band-aid > option _and_ have a list of either machines' dmi strings that have this > problem, or devices' PCI IDs (*), and enable the surprise event handling > for such machine

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-22 Thread Michal Marek
On 20.3.2013 20:08, Takashi Iwai wrote: > At Wed, 20 Mar 2013 12:09:13 -0600, > Alex Williamson wrote: >> >> On Wed, 2013-03-20 at 15:02 +0100, Takashi Iwai wrote: >>> We encountered a problem that on some HP machines the Realtek PCI-e >>> card reader device appears only when you inserted a card be

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Matthew Garrett
On Wed, Mar 20, 2013 at 08:23:39PM +0100, Takashi Iwai wrote: > At Wed, 20 Mar 2013 19:12:50 +, > Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote: > > > I'm afraid that it's too radical to enable always. > > > > Why? > > Because I'm conservative :) > We

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 19:12:50 +, Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote: > > At Wed, 20 Mar 2013 17:52:34 +, > > Matthew Garrett wrote: > > > Well that just sounds like a bug. What's the downside to just ignoring > > > that capability bit? >

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 19:41:38 +0100, Martin Mokrejs wrote: > > Hi Takashi, > would you please describe your test system in more detail? How > about 'lspci -tv'? And 'lsusb -v' of the broken device? I left the machine in my office, so I'll give details tomorrow. It's a Realtek 5249 PCI-e card rea

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Matthew Garrett
On Wed, Mar 20, 2013 at 08:11:15PM +0100, Takashi Iwai wrote: > At Wed, 20 Mar 2013 17:52:34 +, > Matthew Garrett wrote: > > Well that just sounds like a bug. What's the downside to just ignoring > > that capability bit? > > I'm afraid that it's too radical to enable always. Why? > Or, what

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 17:52:34 +, Matthew Garrett wrote: > > On Wed, Mar 20, 2013 at 03:02:01PM +0100, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the > > cold boot. While debuggi

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 12:09:13 -0600, Alex Williamson wrote: > > On Wed, 2013-03-20 at 15:02 +0100, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the > > cold boot. While debugging, it

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Martin Mokrejs
Martin Mokrejs wrote: > Hi Takashi, > would you please describe your test system in more detail? How > about 'lspci -tv'? And 'lsusb -v' of the broken device? > > 1. For me on Dell Vostro 3550 with a SandyBridge chip doing all > SATA+USB2+ExpressCardSlot: > > 00:00.0 Host bridge: Intel Corpora

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Martin Mokrejs
Hi Takashi, would you please describe your test system in more detail? How about 'lspci -tv'? And 'lsusb -v' of the broken device? 1. For me on Dell Vostro 3550 with a SandyBridge chip doing all SATA+USB2+ExpressCardSlot: 00:00.0 Host bridge: Intel Corporation 2nd Generation Core Processor Fam

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 15:02 +0100, Takashi Iwai wrote: > We encountered a problem that on some HP machines the Realtek PCI-e > card reader device appears only when you inserted a card before the > cold boot. While debugging, it turned out that the device is actually > handled via PCI-e hotplug in

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Matthew Garrett
On Wed, Mar 20, 2013 at 03:02:01PM +0100, Takashi Iwai wrote: > We encountered a problem that on some HP machines the Realtek PCI-e > card reader device appears only when you inserted a card before the > cold boot. While debugging, it turned out that the device is actually > handled via PCI-e hotp

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
At Wed, 20 Mar 2013 09:33:18 -0700, Randy Dunlap wrote: > > On 03/20/13 07:02, Takashi Iwai wrote: > > We encountered a problem that on some HP machines the Realtek PCI-e > > card reader device appears only when you inserted a card before the > > cold boot. While debugging, it turned out that the

Re: [PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Randy Dunlap
On 03/20/13 07:02, Takashi Iwai wrote: > We encountered a problem that on some HP machines the Realtek PCI-e > card reader device appears only when you inserted a card before the > cold boot. While debugging, it turned out that the device is actually > handled via PCI-e hotplug in some level. The

[PATCH] pciehp: Add pciehp_surprise module option

2013-03-20 Thread Takashi Iwai
We encountered a problem that on some HP machines the Realtek PCI-e card reader device appears only when you inserted a card before the cold boot. While debugging, it turned out that the device is actually handled via PCI-e hotplug in some level. The device sends a presence change notification, a