Re: [PATCH] pda_power: remove ac_draw_failed goto and label

2012-09-21 Thread Paul Parsons
Hello Anton, On 22/09/12 00:51, Anton Vorontsov wrote: On Fri, Sep 21, 2012 at 01:56:43AM +0100, Paul Parsons wrote: A previous patch added the ac_draw_failed goto and label to pda_power_probe(). The goto would be invoked after a failed call to regulator_get(). However the way ac_draw is used

Re: [PATCH] pda_power: remove ac_draw_failed goto and label

2012-09-21 Thread Anton Vorontsov
On Fri, Sep 21, 2012 at 01:56:43AM +0100, Paul Parsons wrote: > A previous patch added the ac_draw_failed goto and label to > pda_power_probe(). The goto would be invoked after a failed call to > regulator_get(). > > However the way ac_draw is used - always after a check for NULL - > suggests that

[PATCH] pda_power: remove ac_draw_failed goto and label

2012-09-20 Thread Paul Parsons
A previous patch added the ac_draw_failed goto and label to pda_power_probe(). The goto would be invoked after a failed call to regulator_get(). However the way ac_draw is used - always after a check for NULL - suggests that a failed call to regulator_get() was not fatal. This patch removes the