Re: [PATCH] percpu: remove spurious lock dependency between percpu and sched

2019-05-08 Thread Dennis Zhou
On Wed, May 08, 2019 at 12:04:08PM -0700, Eric Dumazet wrote: > On Wed, May 8, 2019 at 11:59 AM Dennis Zhou wrote: > > > > On Tue, May 07, 2019 at 06:43:20PM -0700, John Sperbeck wrote: > > > In free_percpu() we sometimes call pcpu_schedule_balance_work() to > > > queue a work item (which does a

Re: [PATCH] percpu: remove spurious lock dependency between percpu and sched

2019-05-08 Thread Eric Dumazet
On Wed, May 8, 2019 at 11:59 AM Dennis Zhou wrote: > > On Tue, May 07, 2019 at 06:43:20PM -0700, John Sperbeck wrote: > > In free_percpu() we sometimes call pcpu_schedule_balance_work() to > > queue a work item (which does a wakeup) while holding pcpu_lock. > > This creates an unnecessary lock

Re: [PATCH] percpu: remove spurious lock dependency between percpu and sched

2019-05-08 Thread Dennis Zhou
On Tue, May 07, 2019 at 06:43:20PM -0700, John Sperbeck wrote: > In free_percpu() we sometimes call pcpu_schedule_balance_work() to > queue a work item (which does a wakeup) while holding pcpu_lock. > This creates an unnecessary lock dependency between pcpu_lock and > the scheduler's pi_lock.

[PATCH] percpu: remove spurious lock dependency between percpu and sched

2019-05-07 Thread John Sperbeck
In free_percpu() we sometimes call pcpu_schedule_balance_work() to queue a work item (which does a wakeup) while holding pcpu_lock. This creates an unnecessary lock dependency between pcpu_lock and the scheduler's pi_lock. There are other places where we call pcpu_schedule_balance_work() without