Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-08-15 Thread Madhavan Srinivasan
On Thursday 11 August 2016 05:57 PM, Peter Zijlstra wrote: Sorry, found it in my inbox while clearing out backlog.. On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: When decoding the perf_regs mask in perf_output_sample_regs(), we loop through the mask using

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-08-15 Thread Madhavan Srinivasan
On Thursday 11 August 2016 05:57 PM, Peter Zijlstra wrote: Sorry, found it in my inbox while clearing out backlog.. On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: When decoding the perf_regs mask in perf_output_sample_regs(), we loop through the mask using

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-08-11 Thread Peter Zijlstra
Sorry, found it in my inbox while clearing out backlog.. On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > When decoding the perf_regs mask in perf_output_sample_regs(), > we loop through the mask using find_first_bit and find_next_bit functions. > While the exisitng code

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-08-11 Thread Peter Zijlstra
Sorry, found it in my inbox while clearing out backlog.. On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > When decoding the perf_regs mask in perf_output_sample_regs(), > we loop through the mask using find_first_bit and find_next_bit functions. > While the exisitng code

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-04 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 04, 2016 at 10:19:06AM +0300, Yury Norov escreveu: > On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > > When decoding the perf_regs mask in perf_output_sample_regs(), > > we loop through the mask using find_first_bit and find_next_bit functions. > > While the

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-04 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 04, 2016 at 10:19:06AM +0300, Yury Norov escreveu: > On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > > When decoding the perf_regs mask in perf_output_sample_regs(), > > we loop through the mask using find_first_bit and find_next_bit functions. > > While the

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-04 Thread Yury Norov
On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > When decoding the perf_regs mask in perf_output_sample_regs(), > we loop through the mask using find_first_bit and find_next_bit functions. > While the exisitng code works fine in most of the case, > the logic is broken for

Re: [PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-04 Thread Yury Norov
On Sun, Jul 03, 2016 at 11:31:58PM +0530, Madhavan Srinivasan wrote: > When decoding the perf_regs mask in perf_output_sample_regs(), > we loop through the mask using find_first_bit and find_next_bit functions. > While the exisitng code works fine in most of the case, > the logic is broken for

[PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-03 Thread Madhavan Srinivasan
When decoding the perf_regs mask in perf_output_sample_regs(), we loop through the mask using find_first_bit and find_next_bit functions. While the exisitng code works fine in most of the case, the logic is broken for 32bit kernel (Big Endian). When reading u64 mask using (u32 *)()[0],

[PATCH] perf/core: Fix the mask in perf_output_sample_regs

2016-07-03 Thread Madhavan Srinivasan
When decoding the perf_regs mask in perf_output_sample_regs(), we loop through the mask using find_first_bit and find_next_bit functions. While the exisitng code works fine in most of the case, the logic is broken for 32bit kernel (Big Endian). When reading u64 mask using (u32 *)()[0],