Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-23 Thread Christian Borntraeger
On 23/04/14 13:45, Jiri Olsa wrote: > On Mon, Apr 21, 2014 at 07:43:50PM +0400, Alexander Yarygin wrote: [...] >> And a bit of offtopic :) >> Apparently, s390 doesn't have syscalls:*, so some of the tests >> don't work properly (or maybe I missed something? I set >> CONFIG_FTRACE_SYSCALLS >> to 'y

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-23 Thread Jiri Olsa
On Mon, Apr 21, 2014 at 07:43:50PM +0400, Alexander Yarygin wrote: SNIP > > --- a/tools/perf/tests/parse-events.c > +++ b/tools/perf/tests/parse-events.c > @@ -1346,6 +1346,12 @@ static struct evlist_test test__events[] = { > .name = "{cycles,cache-misses,branch-misses}:D", >

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-23 Thread Christian Borntraeger
On 17/04/14 16:40, Jiri Olsa wrote: > On Mon, Mar 24, 2014 at 09:49:00PM +0100, Christian Borntraeger wrote: >> From: Alexander Yarygin >> >> Trace events potentially can have a '-' in their trace system name, >> e.g. kvm on s390 defines kvm-s390:* tracepoints. >> tools/perf could not parse them,

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-21 Thread Alexander Yarygin
At Thu, 17 Apr 2014 13:32:21 +0200, Jiri Olsa wrote: > > On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote: > > Il 24/03/2014 21:49, Christian Borntraeger ha scritto: > > > event_legacy_tracepoint: > > >+PE_NAME '-' PE_NAME ':' PE_NAME > > >+{ > > >+ struct parse_events_evlist *data =

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-17 Thread Jiri Olsa
On Mon, Mar 24, 2014 at 09:49:00PM +0100, Christian Borntraeger wrote: > From: Alexander Yarygin > > Trace events potentially can have a '-' in their trace system name, > e.g. kvm on s390 defines kvm-s390:* tracepoints. > tools/perf could not parse them, because there was no rule for this: > $ su

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-17 Thread Jiri Olsa
On Thu, Apr 17, 2014 at 01:41:56PM +0200, Christian Borntraeger wrote: > On 17/04/14 13:32, Jiri Olsa wrote: > > On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote: > >> Il 24/03/2014 21:49, Christian Borntraeger ha scritto: > >>> event_legacy_tracepoint: > >>> +PE_NAME '-' PE_NAME ':' P

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-17 Thread Christian Borntraeger
On 17/04/14 13:32, Jiri Olsa wrote: > On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote: >> Il 24/03/2014 21:49, Christian Borntraeger ha scritto: >>> event_legacy_tracepoint: >>> +PE_NAME '-' PE_NAME ':' PE_NAME >>> +{ >>> + struct parse_events_evlist *data = _data; >>> + struct li

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-04-17 Thread Jiri Olsa
On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote: > Il 24/03/2014 21:49, Christian Borntraeger ha scritto: > > event_legacy_tracepoint: > >+PE_NAME '-' PE_NAME ':' PE_NAME > >+{ > >+struct parse_events_evlist *data = _data; > >+struct list_head *list; > >+char sys_name[strl

Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-03-25 Thread Paolo Bonzini
Il 24/03/2014 21:49, Christian Borntraeger ha scritto: event_legacy_tracepoint: +PE_NAME '-' PE_NAME ':' PE_NAME +{ + struct parse_events_evlist *data = _data; + struct list_head *list; + char sys_name[strlen($1) + strlen($3) + 2]; + sprintf(&sys_name, "%s-%s", $1, $3); +

[PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

2014-03-24 Thread Christian Borntraeger
From: Alexander Yarygin Trace events potentially can have a '-' in their trace system name, e.g. kvm on s390 defines kvm-s390:* tracepoints. tools/perf could not parse them, because there was no rule for this: $ sudo ./perf top -e "kvm-s390:*" invalid or unsupported event: 'kvm-s390:*' This patc