Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Andi Kleen
On Mon, Jul 17, 2017 at 01:37:58PM +0200, Jiri Olsa wrote: > On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > > Jiri Olsa writes: > > > > > > Setting the reset field to 0 for freq events. > > > > Looks good to me. > > > > Reviewed-by: Andi Kleen

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Andi Kleen
On Mon, Jul 17, 2017 at 01:37:58PM +0200, Jiri Olsa wrote: > On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > > Jiri Olsa writes: > > > > > > Setting the reset field to 0 for freq events. > > > > Looks good to me. > > > > Reviewed-by: Andi Kleen > > > > BTW I suspect there's a

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Jiri Olsa
On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > Jiri Olsa writes: > > > > Setting the reset field to 0 for freq events. > > Looks good to me. > > Reviewed-by: Andi Kleen > > BTW I suspect there's a related bug that > > perf record -e

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Jiri Olsa
On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > Jiri Olsa writes: > > > > Setting the reset field to 0 for freq events. > > Looks good to me. > > Reviewed-by: Andi Kleen > > BTW I suspect there's a related bug that > > perf record -e '{cycles:pp,branches}:S' .. > > would

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Jiri Olsa
On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > Jiri Olsa writes: > > > > Setting the reset field to 0 for freq events. > > Looks good to me. > > Reviewed-by: Andi Kleen > > BTW I suspect there's a related bug that > > perf record -e

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-17 Thread Jiri Olsa
On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > Jiri Olsa writes: > > > > Setting the reset field to 0 for freq events. > > Looks good to me. > > Reviewed-by: Andi Kleen > > BTW I suspect there's a related bug that > > perf record -e '{cycles:pp,branches}:S' .. > > would

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-14 Thread Andi Kleen
Jiri Olsa writes: > > Setting the reset field to 0 for freq events. Looks good to me. Reviewed-by: Andi Kleen BTW I suspect there's a related bug that perf record -e '{cycles:pp,branches}:S' .. would enable multi record PEBS, even though it shouldn't

Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-14 Thread Andi Kleen
Jiri Olsa writes: > > Setting the reset field to 0 for freq events. Looks good to me. Reviewed-by: Andi Kleen BTW I suspect there's a related bug that perf record -e '{cycles:pp,branches}:S' .. would enable multi record PEBS, even though it shouldn't because we need the PMI to read the

[PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-14 Thread Jiri Olsa
There's a bug in PEBs event enabling code, that prevents PEBS freq events to work properly after non freq PEBS event was run. freq events - perf_event_attr::freq set -F option of perf record PEBS events - perf_event_attr::precise_ip > 0 default for perf record Like

[PATCH] perf/x86/intel: Fix debug_store reset field for freq events

2017-07-14 Thread Jiri Olsa
There's a bug in PEBs event enabling code, that prevents PEBS freq events to work properly after non freq PEBS event was run. freq events - perf_event_attr::freq set -F option of perf record PEBS events - perf_event_attr::precise_ip > 0 default for perf record Like