[PATCH] perf: correct SNOOPX field offset

2020-09-21 Thread Al Grant
perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. These are distinct fields, and the bitfield layout in perf_mem_data_src confirms that SNOOPX should be at offset 38. Fixes: 52839e653b5629bd ("perf tools: Add

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Peter Zijlstra
bit as it fixes the tooling, > > > please consider taking the kernel part. > > > > Al, can you resend with the right people on Cc? Also see below. > > > > > --- > > > > > > From: Al Grant > > > Subject: [PATCH] perf: correc

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread peterz
ct the > tools/include/uapi/linux/perf_event.h bit as it fixes the tooling, > please consider taking the kernel part. Al, can you resend with the right people on Cc? Also see below. > --- > > From: Al Grant > Subject: [PATCH] perf: correct SNOOPX field offset > Message-ID:

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Cc? Also see below. > > > --- > > > > From: Al Grant > > Subject: [PATCH] perf: correct SNOOPX field offset > > Message-ID: <9974f2d0-bf7f-518e-d9f7-4520e5ff1...@foss.arm.com> > > Date: Mon, 24 Aug 2020 10:28:34 +0100 > > > > perf_ev

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Al Grant
On 01/09/2020 16:02, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: pe

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
t; well. Also you mixed up tools/ with include/ things, the perf part of the kernel is maintained by Ingo, PeterZ. Peter, the patch is the one below, I'll collect the tools/include/uapi/linux/perf_event.h bit as it fixes the tooling, please consider taking the kernel part. Thanks, - A

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > > > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > > > perf_event.h has macros that define the fiel

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Al Grant
On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offs

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > perf_event.h has macros that define the field offsets in the > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets > > were both 37. These are distinct fields

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Mark Rutland
Hi, [ adding the kernel-side perf maintainers ] Please note that scripts/get_maintainer.pl can help to find relevant maintainers. On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > perf_event.h has macros that define the field offsets in the > data_src bitmask in perf records. The SNOOP

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-25 Thread Andi Kleen
On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > perf_event.h has macros that define the field offsets in the > data_src bitmask in perf records. The SNOOPX and REMOTE offsets > were both 37. These are distinct fields, and the bitfield layout > in perf_mem_data_src confirms that SNOOPX s

[PATCH] perf: correct SNOOPX field offset

2020-08-24 Thread Al Grant
perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. These are distinct fields, and the bitfield layout in perf_mem_data_src confirms that SNOOPX should be at offset 38. From: Al Grant include/uapi/linux/perf