Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Arnaldo Carvalho de Melo
Em Tue, May 26, 2015 at 05:48:27PM +0200, Martin Liška escreveu: > On 05/26/2015 04:36 PM, Arnaldo Carvalho de Melo wrote: > >Em Tue, May 26, 2015 at 11:13:32AM +0200, Martin Liška escreveu: > >>>* Arnaldo Carvalho de Melo wrote: > Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreve

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Martin Liška
On 05/26/2015 04:36 PM, Arnaldo Carvalho de Melo wrote: Em Tue, May 26, 2015 at 11:13:32AM +0200, Martin Liška escreveu: On 05/25/2015 08:32 PM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreveu: On 05/25/2015 01:09 PM, Ing

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Martin Liška
On 05/26/2015 05:22 PM, Arnaldo Carvalho de Melo wrote: Em Tue, May 26, 2015 at 11:36:26AM -0300, Arnaldo Carvalho de Melo escreveu: Em Tue, May 26, 2015 at 11:13:32AM +0200, Martin Liška escreveu: As Arnaldo pointed, I split the patch to following 2 smaller patches. Thanks, but how did you g

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Arnaldo Carvalho de Melo
Em Tue, May 26, 2015 at 11:36:26AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, May 26, 2015 at 11:13:32AM +0200, Martin Liška escreveu: > > As Arnaldo pointed, I split the patch to following 2 smaller patches. > > Thanks, but how did you generated the two attached patches? > > [acme@ssd

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Arnaldo Carvalho de Melo
Em Tue, May 26, 2015 at 11:13:32AM +0200, Martin Liška escreveu: > On 05/25/2015 08:32 PM, Ingo Molnar wrote: > > > >* Arnaldo Carvalho de Melo wrote: > > > >>Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreveu: > >>>On 05/25/2015 01:09 PM, Ingo Molnar wrote: > > * Martin Lišk

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-26 Thread Martin Liška
On 05/25/2015 08:32 PM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreveu: On 05/25/2015 01:09 PM, Ingo Molnar wrote: * Martin Liška wrote: Right optimize debugging experience is given by passing -Og to compiler. Assign

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreveu: > > On 05/25/2015 01:09 PM, Ingo Molnar wrote: > > > > > >* Martin Liška wrote: > > > > > Right optimize debugging experience is given by passing -Og to > > compiler. Assign default valu

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Arnaldo Carvalho de Melo
Em Mon, May 25, 2015 at 01:12:44PM +0200, Martin Liška escreveu: > On 05/25/2015 01:09 PM, Ingo Molnar wrote: > > > >* Martin Liška wrote: > > > Right optimize debugging experience is given by passing -Og to > compiler. Assign default value for pointers that are identified by > compile

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Martin Liška
On 05/25/2015 01:09 PM, Ingo Molnar wrote: * Martin Liška wrote: Right optimize debugging experience is given by passing -Og to compiler. Assign default value for pointers that are identified by compiler as non-initialized. s/Right optimize debugging experience is given/ Correct debuggin

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Ingo Molnar
* Martin Liška wrote: > >>Right optimize debugging experience is given by passing -Og to > >>compiler. Assign default value for pointers that are identified by > >>compiler as non-initialized. > > > >s/Right optimize debugging experience is given/ > > Correct debugging experience is given/ >

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Martin Liška
On 05/25/2015 12:47 PM, Ingo Molnar wrote: * Martin Liška wrote: Currently, GCC optimizes -O6 same as -O3 level, thus change the value to -O6. s/to -O6 to -O3 Right optimize debugging experience is given by passing -Og to compiler. Assign default value for pointers that are identified

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Ingo Molnar
* Martin Liška wrote: > Currently, GCC optimizes -O6 same as -O3 level, thus change the value > to -O6. s/to -O6 to -O3 > Right optimize debugging experience is given by passing -Og to > compiler. Assign default value for pointers that are identified by > compiler as non-initialized. s/Ri

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-25 Thread Martin Liška
On 05/22/2015 09:02 AM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: Em Wed, May 20, 2015 at 06:16:51PM +0200, Martin Liška escreveu: On 05/20/2015 04:55 PM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: So the rule has been: What are the kernel requirements for the toolcha

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-22 Thread Martin Liška
On 05/22/2015 09:02 AM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: Em Wed, May 20, 2015 at 06:16:51PM +0200, Martin Liška escreveu: On 05/20/2015 04:55 PM, Ingo Molnar wrote: * Arnaldo Carvalho de Melo wrote: So the rule has been: What are the kernel requirements for the toolcha

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-22 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2015 at 06:16:51PM +0200, Martin Liška escreveu: > > On 05/20/2015 04:55 PM, Ingo Molnar wrote: > > >* Arnaldo Carvalho de Melo wrote: > > >>So the rule has been: What are the kernel requirements for the > > >>toolchain? tools/perf/ should bui

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-21 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2015 at 06:16:51PM +0200, Martin Liška escreveu: > On 05/20/2015 04:55 PM, Ingo Molnar wrote: > >* Arnaldo Carvalho de Melo wrote: > >>So the rule has been: What are the kernel requirements for the > >>toolchain? tools/perf/ should build with that. > > > >So we could use -Og if it

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Martin Liška
e: Thu, 2 Apr 2015 15:24:49 +0200 Subject: [PATCH] perf: fix wrong DEBUG configuration Currently, GCC optimizes -O6 same as -O3 level, thus change the value to -O6. Right optimize debugging experience is given by passing -Og to compiler. Assign default value for pointers that are identified by co

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2015 at 03:29:37PM +0200, Martin Liška escreveu: > > On 05/20/2015 03:17 PM, Arnaldo Carvalho de Melo wrote: > > >Em Wed, May 20, 2015 at 03:07:39PM +0200, Martin Liška escreveu: > > >>Currently, GCC optimizes -O6 same as -O3 level. Right optim

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2015 at 03:29:37PM +0200, Martin Liška escreveu: > On 05/20/2015 03:17 PM, Arnaldo Carvalho de Melo wrote: > >Em Wed, May 20, 2015 at 03:07:39PM +0200, Martin Liška escreveu: > >>Currently, GCC optimizes -O6 same as -O3 level. Right optimize debugging > >>experience is given by pass

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Martin Liška
:49 +0200 Subject: [PATCH] perf: fix wrong DEBUG configuration Currently, GCC optimizes -O6 same as -O3 level. Right optimize debugging experience is given by passing -Og to compiler. Assign default value for pointers that are identified by compiler as non-initialized. Signed-off-by: Martin Li

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Arnaldo Carvalho de Melo
n-initialized. > > Signed-off-by: Martin Liska > >From b5f2b42b279ab497e92d41e1f4021dd5cb6ae3ce Mon Sep 17 00:00:00 2001 > From: mliska > Date: Thu, 2 Apr 2015 15:24:49 +0200 > Subject: [PATCH] perf: fix wrong DEBUG configuration > > Currently, GCC optimizes -O6 same as -O3 level. Right optimize de

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-20 Thread Martin Liška
ence is given by passing -Og to compiler. Assign default value for pointers that are identified by compiler as non-initialized. Signed-off-by: Martin Liska >From b5f2b42b279ab497e92d41e1f4021dd5cb6ae3ce Mon Sep 17 00:00:00 2001 From: mliska Date: Thu, 2 Apr 2015 15:24:49 +0200 Subject: [P

Re: [PATCH] perf: fix wrong DEBUG configuration

2015-05-19 Thread Arnaldo Carvalho de Melo
Em Tue, May 19, 2015 at 03:41:03PM +0200, Martin Liška escreveu: > Following patch is fix for wrong DEBUG configuration. Can you please state, in the changelog, what you think is wrong and how your proposed change fixes it, so that after reading your intent I can go and look at the code to see if

[PATCH] perf: fix wrong DEBUG configuration

2015-05-19 Thread Martin Liška
Following patch is fix for wrong DEBUG configuration. Signed-off-by: Martin Liska --- tools/perf/arch/common.c| 2 +- tools/perf/config/Makefile | 2 +- tools/perf/util/symbol.c| 2 +- tools/perf/util/trace-event-parse.c | 2 +- 4 files changed, 4 insertions(+),